|WARNING| pw109518 [PATCH] [v2] common/sff_module: add telemetry command to dump module EEPROM

|WARNING| pw109518 [PATCH] [v2] common/sff_module: add telemetry command to dump module EEPROM

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 6897 bytes --]

Test-Label: iol-abi-testing
Test-Status: WARNING
http://dpdk.org/patch/109518

_Testing issues_

Submitter: Zhang, RobinX <robinx.zhang@intel.com>
Date: Friday, April 08 2022 10:23:30 
DPDK git baseline: Repo:dpdk
  Branch: master
  CommitID:b35c4b0aa2bcd242d8b1989acaa41fed154045c7

109518 --> testing fail

Test environment and result as below:

+------------------+----------+
|   Environment    | abi_test |
+==================+==========+
| Fedora 33        | FAIL     |
+------------------+----------+
| Fedora 34 clang  | FAIL     |
+------------------+----------+
| Arch Linux       | FAIL     |
+------------------+----------+
| Fedora 34        | FAIL     |
+------------------+----------+
| Fedora 32        | FAIL     |
+------------------+----------+
| RHEL 7           | PASS     |
+------------------+----------+
| Ubuntu 18.04     | PASS     |
+------------------+----------+
| RHEL8            | PASS     |
+------------------+----------+
| Fedora 31        | PASS     |
+------------------+----------+
| Ubuntu 20.04     | PASS     |
+------------------+----------+
| CentOS Stream 8  | PASS     |
+------------------+----------+
| openSUSE Leap 15 | PASS     |
+------------------+----------+

==== 20 line log output for Fedora 32 (abi_test): ====
[585/3529] Compiling C object 'drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_8636.c.o'.
[586/3529] Generating rte_common_sff_module_mingw with a custom command.
[587/3529] Linking static target drivers/libtmp_rte_common_sff_module.a.
[588/3529] Generating rte_common_sff_module.pmd.c with a custom command.
[589/3529] Compiling C object 'drivers/a715181@@rte_common_sff_module@sta/meson-generated_.._rte_common_sff_module.pmd.c.o'.
[590/3529] Linking static target drivers/librte_common_sff_module.a.
[591/3529] Generating rte_common_sff_module_def with a custom command.
[592/3529] Compiling C object 'drivers/a715181@@rte_common_sff_module@sha/meson-generated_.._rte_common_sff_module.pmd.c.o'.
[593/3529] Compiling C object 'drivers/a715181@@tmp_rte_bus_auxiliary@sta/bus_auxiliary_auxiliary_common.c.o'.
[594/3529] Linking target drivers/librte_common_sff_module.so.22.2.
FAILED: drivers/librte_common_sff_module.so.22.2
ccache cc  -o drivers/librte_common_sff_module.so.22.2 'drivers/a715181@@rte_common_sff_module@sha/meson-generated_.._rte_common_sff_module.pmd.c.o' 'drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_common.c.o' 'drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_8079.c.o' 'drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_8472.c.o' 'drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_8636.c.o' 'drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_telemetry.c.o' -Wl,--no-undefined -Wl,--as-needed -shared -fPIC -Wl,--start-group -Wl,-soname,librte_common_sff_module.so.22 -Wl,--no-as-needed -pthread -lm -ldl -lnuma lib/librte_eal.so.22.2 lib/librte_kvargs.so.22.2 lib/librte_telemetry.so.22.2 lib/librte_ethdev.so.22.2 lib/librte_net.so.22.2 lib/librte_mbuf.so.22.2 lib/librte_mempool.so.22.2 lib/librte_ring.so.22.2 lib/librte_meter.so.22.2 -Wl,--end-group -Wl,--version-script=/home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI@4/dpdk/drivers/common/sff_module/version.map '-Wl,-rpath,$ORIGIN/../lib' -Wl,-rpath-link,/home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI@4/dpdk/build/lib
/usr/bin/ld: drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_8079.c.o:/home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI@4/dpdk/build/../drivers/common/sff_module/sff_telemetry.h:25: multiple definition of `sff_item_count'; drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_common.c.o:/home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI@4/dpdk/build/../drivers/common/sff_module/sff_telemetry.h:25: first defined here
/usr/bin/ld: drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_8472.c.o:/home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI@4/dpdk/build/../drivers/common/sff_module/sff_telemetry.h:25: multiple definition of `sff_item_count'; drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_common.c.o:/home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI@4/dpdk/build/../drivers/common/sff_module/sff_telemetry.h:25: first defined here
/usr/bin/ld: drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_8636.c.o:/home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI@4/dpdk/build/../drivers/common/sff_module/sff_telemetry.h:25: multiple definition of `sff_item_count'; drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_common.c.o:/home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI@4/dpdk/build/../drivers/common/sff_module/sff_telemetry.h:25: first defined here
/usr/bin/ld: drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_telemetry.c.o:/home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI@4/dpdk/build/../drivers/common/sff_module/sff_telemetry.h:25: multiple definition of `sff_item_count'; drivers/a715181@@tmp_rte_common_sff_module@sta/common_sff_module_sff_common.c.o:/home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI@4/dpdk/build/../drivers/common/sff_module/sff_telemetry.h:25: first defined here
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
==== Creating reference DPDK ABI
Error: install directory 'build_install' does not exist.
==== End log output ====

Fedora 33
	Kernel: 5.4.0-72-generic
	Compiler: gcc 10.3.1 20210422 (Red Hat 10.3.1-1)

Fedora 34 clang
	Kernel: 5.4.0-72-generic
	Compiler: clang 12.0.0 (Fedora 12.0.0-0.3.rc1.fc34)

Arch Linux
	Kernel: 5.4.0-73-generic
	Compiler: gcc 11.1.0

Fedora 34
	Kernel: 5.4.0-72-generic
	Compiler: gcc 11.1.1 20210428 (Red Hat 11.1.1-1)

Fedora 32
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 10.2.1

RHEL 7
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 4.8.5 20150623 (Red Hat 4.8.5-44)

Ubuntu 18.04
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 7.5.0-3ubuntu1~18.04

RHEL8
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 8.3.1 20191121 (Red Hat 8.3.1-5)

Fedora 31
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 9.3.1

Ubuntu 20.04
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 9.3.0-17ubuntu1~20.04

CentOS Stream 8
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 8.4.1 20200928

openSUSE Leap 15
	Kernel: 4.18.0-240.10.1.el8_3.x86_64
	Compiler: gcc 7.5.0

To view detailed results, visit:
https://lab.dpdk.org/results/dashboard/patchsets/21735/

UNH-IOL DPDK Community Lab

To manage your email subscriptions, visit: 
https://lab.dpdk.org/results/dashboard/preferences/subscriptions/

|WARNING| pw109518 [PATCH v2] common/sff_module: add telemetry command to dump module EEPROM

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/109518

_coding style issues_


ERROR:TRAILING_WHITESPACE: trailing whitespace
#866: FILE: drivers/common/sff_module/sff_8472.c:33:
+ * This is the offset at which the A2 page is in the EEPROM $

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1592: FILE: drivers/common/sff_module/sff_8636.c:452:
+		printf("%s 40G OTN (OTU3B/OTU3C)
", pfx);

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1592: FILE: drivers/common/sff_module/sff_8636.c:452:
+		printf("%s 40G OTN (OTU3B/OTU3C)
", pfx);

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1593: FILE: drivers/common/sff_module/sff_8636.c:453:
+		add_item_string(items, name_string, "40G OTN (OTU3B/OTU3C)");

WARNING:TYPO_SPELLING: 'OTU' may be misspelled - perhaps 'OUT'?
#1593: FILE: drivers/common/sff_module/sff_8636.c:453:
+		add_item_string(items, name_string, "40G OTN (OTU3B/OTU3C)");

WARNING:TYPO_SPELLING: 'gurantee' may be misspelled - perhaps 'guarantee'?
#2022: FILE: drivers/common/sff_module/sff_8636.c:882:
+	 * of page 3, will provide the gurantee for existence of alarms

WARNING:TYPO_SPELLING: 'Celcius' may be misspelled - perhaps ''?
#3336: FILE: drivers/common/sff_module/sff_common.h:167:
+	/* SFP Temp in 16-bit signed 1/256 Celcius */

ERROR:CODE_INDENT: code indent should use tabs where possible
#3534: FILE: drivers/common/sff_module/sff_telemetry.h:19:
+        char name[SFF_ITEM_NAME_SIZE];    /* The item name. */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3534: FILE: drivers/common/sff_module/sff_telemetry.h:19:
+        char name[SFF_ITEM_NAME_SIZE];    /* The item name. */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#3535: FILE: drivers/common/sff_module/sff_telemetry.h:20:
+        char value[SFF_ITEM_VALUE_SIZE];  /* The item value. */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#3535: FILE: drivers/common/sff_module/sff_telemetry.h:20:
+        char value[SFF_ITEM_VALUE_SIZE];  /* The item value. */$

total: 3 errors, 8 warnings, 3389 lines checked