From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Abdelfattah Chehab <abdelfattah.chehab-ext@ekinops.com>
Subject: |WARNING| pw109628 [PATCH] vmbus: get current rte_vmbus_bus struct
Date: Wed, 13 Apr 2022 09:32:23 +0200 (CEST) [thread overview]
Message-ID: <20220413073223.263A2120DB4@dpdk.org> (raw)
In-Reply-To: <PR1P264MB2030EB80D45C19826E935ADFDFEA9@PR1P264MB2030.FRAP264.PROD.OUTLOOK.COM>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/109628
_coding style issues_
ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#127: FILE: dpdk-20.11/drivers/bus/vmbus/rte_bus_vmbus.h:425:
#ifdef __cplusplus
ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#146: FILE: dpdk-20.11/drivers/bus/vmbus/vmbus_common.c:27:
+int rte_vmbus_get_bus(struct rte_vmbus_bus *bus){
ERROR:SPACING: space required before the open brace '{'
#146: FILE: dpdk-20.11/drivers/bus/vmbus/vmbus_common.c:27:
+int rte_vmbus_get_bus(struct rte_vmbus_bus *bus){
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#148: FILE: dpdk-20.11/drivers/bus/vmbus/vmbus_common.c:29:
+ if (!bus)$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (2, 4)
#148: FILE: dpdk-20.11/drivers/bus/vmbus/vmbus_common.c:29:
+ if (!bus)
+ return 1;
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#149: FILE: dpdk-20.11/drivers/bus/vmbus/vmbus_common.c:30:
+ return 1;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#151: FILE: dpdk-20.11/drivers/bus/vmbus/vmbus_common.c:32:
+ memcpy(bus, &rte_vmbus_bus, sizeof(struct rte_vmbus_bus));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#153: FILE: dpdk-20.11/drivers/bus/vmbus/vmbus_common.c:34:
+ return 0;$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 4 errors, 5 warnings, 39 lines checked
next parent reply other threads:[~2022-04-13 7:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PR1P264MB2030EB80D45C19826E935ADFDFEA9@PR1P264MB2030.FRAP264.PROD.OUTLOOK.COM>
2022-04-13 7:32 ` checkpatch [this message]
2022-04-13 7:48 dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220413073223.263A2120DB4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=abdelfattah.chehab-ext@ekinops.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).