From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Nithin Dabilpuram <ndabilpuram@marvell.com>
Subject: |WARNING| pw110860 [PATCH v4 19/28] net/cnxk: optimize Rx fast path for security pkts
Date: Sun, 8 May 2022 08:30:05 +0200 (CEST) [thread overview]
Message-ID: <20220508063005.61C901242E3@dpdk.org> (raw)
In-Reply-To: <20220508062616.3398-19-ndabilpuram@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/110860
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_mbuf' - possible side-effects?
#402: FILE: drivers/net/cnxk/cn10k_rx.h:953:
+#define NIX_PUSH_META_TO_FREE(_mbuf, _laddr, _loff_p) \
+ do { \
+ *(uint64_t *)((_laddr) + (*(_loff_p) << 3)) = (uint64_t)_mbuf; \
+ *(_loff_p) = *(_loff_p) + 1; \
+ /* Mark meta mbuf as put */ \
+ RTE_MEMPOOL_CHECK_COOKIES(_mbuf->pool, (void **)&_mbuf, 1, 0); \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_loff_p' - possible side-effects?
#402: FILE: drivers/net/cnxk/cn10k_rx.h:953:
+#define NIX_PUSH_META_TO_FREE(_mbuf, _laddr, _loff_p) \
+ do { \
+ *(uint64_t *)((_laddr) + (*(_loff_p) << 3)) = (uint64_t)_mbuf; \
+ *(_loff_p) = *(_loff_p) + 1; \
+ /* Mark meta mbuf as put */ \
+ RTE_MEMPOOL_CHECK_COOKIES(_mbuf->pool, (void **)&_mbuf, 1, 0); \
+ } while (0)
total: 0 errors, 0 warnings, 2 checks, 608 lines checked
parent reply other threads:[~2022-05-08 6:30 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220508062616.3398-19-ndabilpuram@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220508063005.61C901242E3@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ndabilpuram@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).