From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4139DA0509 for ; Mon, 9 May 2022 11:12:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3046C410EE; Mon, 9 May 2022 11:12:15 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 07319407FF for ; Mon, 9 May 2022 11:12:14 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 002F11242E3; Mon, 9 May 2022 11:12:13 +0200 (CEST) Subject: |WARNING| pw110916 [RFC v2 2/9] net/idpf/base: add OS specific implementation In-Reply-To: <20220509091133.3752306-3-junfeng.guo@intel.com> References: <20220509091133.3752306-3-junfeng.guo@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Junfeng Guo Message-Id: <20220509091214.002F11242E3@dpdk.org> Date: Mon, 9 May 2022 11:12:13 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/110916 _coding style issues_ WARNING:TYPO_SPELLING: 'definations' may be misspelled - perhaps 'definitions'? #67: Add some MACRO definations and small functions which are specific WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(arr) #182: FILE: drivers/net/idpf/base/iecm_osdep.h:100: +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0])) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'h' - possible side-effects? #190: FILE: drivers/net/idpf/base/iecm_osdep.h:108: +#define iecm_debug(h, m, s, ...) \ + do { \ + if (((m) & (h)->debug_mask)) \ + PMD_DRV_LOG_RAW(DEBUG, "iecm %02x.%x " s, \ + (h)->bus.device, (h)->bus.func, \ + ##__VA_ARGS__); \ + } while (0) CHECK:CAMELCASE: Avoid CamelCase: #208: FILE: drivers/net/idpf/base/iecm_osdep.h:126: + "0x%04X 0x%016"PRIx64" ", \ CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #208: FILE: drivers/net/idpf/base/iecm_osdep.h:126: + "0x%04X 0x%016"PRIx64" ", \ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'c' - possible side-effects? #274: FILE: drivers/net/idpf/base/iecm_osdep.h:192: +#define iecm_memdup(a, b, c, d) rte_memcpy(iecm_malloc(a, c), b, c) CHECK:CAMELCASE: Avoid CamelCase: #331: FILE: drivers/net/idpf/base/iecm_osdep.h:249: + snprintf(z_name, sizeof(z_name), "iecm_dma_%"PRIu64, rte_rand()); CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #331: FILE: drivers/net/idpf/base/iecm_osdep.h:249: + snprintf(z_name, sizeof(z_name), "iecm_dma_%"PRIu64, rte_rand()); CHECK:MACRO_ARG_REUSE: Macro argument reuse 'd' - possible side-effects? #384: FILE: drivers/net/idpf/base/iecm_osdep.h:302: +#define DIV_ROUND_UP(n, d) (((n) + (d) - 1) / (d)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'b' - possible side-effects? #397: FILE: drivers/net/idpf/base/iecm_osdep.h:315: +#define DIVIDE_AND_ROUND_UP(a, b) (((a) + (b) - 1) / (b)) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects? #421: FILE: drivers/net/idpf/base/iecm_osdep.h:339: +#define IS_ZERO_ETHER_ADDR(addr) \ + (((bool)((((u16 *)(addr))[0] == ((u16)0x0)))) && \ + ((bool)((((u16 *)(addr))[1] == ((u16)0x0)))) && \ + ((bool)((((u16 *)(addr))[2] == ((u16)0x0))))) total: 0 errors, 2 warnings, 9 checks, 365 lines checked Warning in drivers/net/idpf/base/iecm_osdep.h: Using compiler attribute directly