From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3DE5EA0093
	for <public@inbox.dpdk.org>; Tue, 10 May 2022 17:08:44 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1D66542856;
	Tue, 10 May 2022 17:08:44 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 1DFFA42848
 for <test-report@dpdk.org>; Tue, 10 May 2022 17:08:42 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 0CF761242ED; Tue, 10 May 2022 17:08:42 +0200 (CEST)
Subject: |WARNING| pw110981 [PATCH v2 1/8] eal: add initial support for RISC-V
 architecture
In-Reply-To: <20220510150759.525434-2-kda@semihalf.com>
References: <20220510150759.525434-2-kda@semihalf.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Stanislaw Kardach <kda@semihalf.com>
Message-Id: <20220510150842.0CF761242ED@dpdk.org>
Date: Tue, 10 May 2022 17:08:42 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/110981

_coding style issues_


WARNING:BAD_SIGN_OFF: Non-standard signature: Sponsored-by:
#133: 
Sponsored-by: Frank Zhao <Frank.Zhao@starfivetech.com>

WARNING:BAD_SIGN_OFF: Non-standard signature: Sponsored-by:
#134: 
Sponsored-by: Sam Grove <sam.grove@sifive.com>

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#812: FILE: lib/eal/riscv/include/rte_atomic.h:24:
+#define rte_mb()	asm volatile("fence rw, rw" : : : "memory")

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#814: FILE: lib/eal/riscv/include/rte_atomic.h:26:
+#define rte_wmb()	asm volatile("fence w, w" : : : "memory")

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#816: FILE: lib/eal/riscv/include/rte_atomic.h:28:
+#define rte_rmb()	asm volatile("fence r, r" : : : "memory")

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#824: FILE: lib/eal/riscv/include/rte_atomic.h:36:
+#define rte_io_mb()	asm volatile("fence iorw, iorw" : : : "memory")

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#826: FILE: lib/eal/riscv/include/rte_atomic.h:38:
+#define rte_io_wmb()	asm volatile("fence orw, ow" : : : "memory")

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#828: FILE: lib/eal/riscv/include/rte_atomic.h:40:
+#define rte_io_rmb()	asm volatile("fence ir, ir" : : : "memory")

ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#978: FILE: lib/eal/riscv/include/rte_cycles.h:21:
+#define RV64_CSRR(reg, value) \
+	asm volatile("csrr %0, " #reg : "=r" (value) : : "memory")

WARNING:TYPO_SPELLING: 'hart' may be misspelled - perhaps 'heart'?
#1000: FILE: lib/eal/riscv/include/rte_cycles.h:43:
+/** Read hart cycle counter */

WARNING:TYPO_SPELLING: 'hart' may be misspelled - perhaps 'heart'?
#1009: FILE: lib/eal/riscv/include/rte_cycles.h:52:
+/** Read hart cycle counter ensuring no re-ordering */

total: 7 errors, 4 warnings, 1431 lines checked
Warning in lib/eal/riscv/include/rte_vect.h:
Using compiler attribute directly
Warning in lib/eal/riscv/include/rte_atomic.h:
Using rte_smp_[r/w]mb
Warning in lib/eal/riscv/include/rte_atomic.h:
Using __atomic_thread_fence