automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jeff Daly <jeffd@silicom-usa.com>
Subject: |WARNING| pw111434 [PATCH 3/3] ixgbe: make hotplug detection aware of changed SFPs
Date: Thu, 19 May 2022 19:44:51 +0200 (CEST)	[thread overview]
Message-ID: <20220519174451.C95B1120945@dpdk.org> (raw)
In-Reply-To: <20220519174325.23308-4-jeffd@silicom-usa.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/111434

_coding style issues_


WARNING:BAD_SIGN_OFF: Non-standard signature: Inspired-by:
#112: 
Inspired-by: Stephen Douthit <stephend@silicom-usa.com>

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#219: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:2476:
+	 * */

ERROR:C99_COMMENTS: do not use C99 // comments
#443: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4431:
+//	pthread_detach(pthread_self());

ERROR:CODE_INDENT: code indent should use tabs where possible
#456: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4468:
+                                bool *link_up, bool link_up_wait_to_complete)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#456: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4468:
+                                bool *link_up, bool link_up_wait_to_complete)$

total: 2 errors, 3 warnings, 0 checks, 376 lines checked

           reply	other threads:[~2022-05-19 17:44 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20220519174325.23308-4-jeffd@silicom-usa.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220519174451.C95B1120945@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=jeffd@silicom-usa.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).