From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id BA348A0503
	for <public@inbox.dpdk.org>; Thu, 19 May 2022 19:44:53 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B3D8B40223;
	Thu, 19 May 2022 19:44:53 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id DD63440156
 for <test-report@dpdk.org>; Thu, 19 May 2022 19:44:51 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id C95B1120945; Thu, 19 May 2022 19:44:51 +0200 (CEST)
Subject: |WARNING| pw111434 [PATCH 3/3] ixgbe: make hotplug detection aware of
 changed SFPs
In-Reply-To: <20220519174325.23308-4-jeffd@silicom-usa.com>
References: <20220519174325.23308-4-jeffd@silicom-usa.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Jeff Daly <jeffd@silicom-usa.com>
Message-Id: <20220519174451.C95B1120945@dpdk.org>
Date: Thu, 19 May 2022 19:44:51 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/111434

_coding style issues_


WARNING:BAD_SIGN_OFF: Non-standard signature: Inspired-by:
#112: 
Inspired-by: Stephen Douthit <stephend@silicom-usa.com>

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#219: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:2476:
+	 * */

ERROR:C99_COMMENTS: do not use C99 // comments
#443: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4431:
+//	pthread_detach(pthread_self());

ERROR:CODE_INDENT: code indent should use tabs where possible
#456: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4468:
+                                bool *link_up, bool link_up_wait_to_complete)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#456: FILE: drivers/net/ixgbe/ixgbe_ethdev.c:4468:
+                                bool *link_up, bool link_up_wait_to_complete)$

total: 2 errors, 3 warnings, 0 checks, 376 lines checked