From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Mao YingMing <maoyingming@baidu.com>
Subject: |WARNING| pw114831 [PATCH] net/bnxt: fix null pointer dereference in bnxt_hwrm_port_led_cfg()
Date: Thu, 11 Aug 2022 10:25:12 +0200 (CEST) [thread overview]
Message-ID: <20220811082512.4EC3D120782@dpdk.org> (raw)
In-Reply-To: <1659365401-41425-1-git-send-email-maoyingming@baidu.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114831
_coding style issues_
WARNING:TYPO_SPELLING: 'allways' may be misspelled - perhaps 'always'?
#54:
VFs's "bp->leds" is allways null, check bp->leds is
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!bp->leds'
#87: FILE: drivers/net/bnxt/bnxt_hwrm.c:4538:
+ if (BNXT_VF(bp) || (!bp->leds) || (!bp->leds->num_leds))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around '!bp->leds->num_leds'
#87: FILE: drivers/net/bnxt/bnxt_hwrm.c:4538:
+ if (BNXT_VF(bp) || (!bp->leds) || (!bp->leds->num_leds))
WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email name mismatch: 'From: maoyingming <maoyingming@baidu.com>' != 'Signed-off-by: Mao YingMing <maoyingming@baidu.com>'
total: 0 errors, 2 warnings, 2 checks, 8 lines checked
parent reply other threads:[~2022-08-11 8:25 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1659365401-41425-1-git-send-email-maoyingming@baidu.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811082512.4EC3D120782@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=maoyingming@baidu.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).