From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Pallavi Kadam <pallavi.kadam@intel.com>
Subject: |WARNING| pw114846 [dpdk-kmods v2] windows/netuio: fix BAR parsing
Date: Fri, 12 Aug 2022 00:20:53 +0200 (CEST) [thread overview]
Message-ID: <20220811222053.94551120775@dpdk.org> (raw)
In-Reply-To: <20220811221723.2124-1-pallavi.kadam@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114846
_coding style issues_
ERROR:CODE_INDENT: code indent should use tabs where possible
#115: FILE: windows/netuio/netuio_dev.c:196:
+ ULONG bar_value = pci_config.u.type0.BaseAddresses[bar_index];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: windows/netuio/netuio_dev.c:196:
+ ULONG bar_value = pci_config.u.type0.BaseAddresses[bar_index];$
ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: windows/netuio/netuio_dev.c:198:
+ if (bar_value == 0) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: windows/netuio/netuio_dev.c:198:
+ if (bar_value == 0) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#117: FILE: windows/netuio/netuio_dev.c:198:
+ if (bar_value == 0) {
continue;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#117: FILE: windows/netuio/netuio_dev.c:198:
+ if (bar_value == 0) {
continue;
}
ERROR:CODE_INDENT: code indent should use tabs where possible
#126: FILE: windows/netuio/netuio_dev.c:238:
+ // Skip the next BAR slot used by the current 64-bit address.$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#126: FILE: windows/netuio/netuio_dev.c:238:
+ // Skip the next BAR slot used by the current 64-bit address.$
ERROR:C99_COMMENTS: do not use C99 // comments
#126: FILE: windows/netuio/netuio_dev.c:238:
+ // Skip the next BAR slot used by the current 64-bit address.
ERROR:CODE_INDENT: code indent should use tabs where possible
#127: FILE: windows/netuio/netuio_dev.c:239:
+ if (bar_value & PCI_TYPE_64BIT) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: windows/netuio/netuio_dev.c:239:
+ if (bar_value & PCI_TYPE_64BIT) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#127: FILE: windows/netuio/netuio_dev.c:239:
+ if (bar_value & PCI_TYPE_64BIT) {
+ bar_index++;
WARNING:BRACES: braces {} are not necessary for single statement blocks
#127: FILE: windows/netuio/netuio_dev.c:239:
+ if (bar_value & PCI_TYPE_64BIT) {
+ bar_index++;
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: windows/netuio/netuio_dev.c:240:
+ bar_index++;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: windows/netuio/netuio_dev.c:240:
+ bar_index++;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#129: FILE: windows/netuio/netuio_dev.c:241:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#129: FILE: windows/netuio/netuio_dev.c:241:
+ }$
ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Pallavi Kadam <pallavi.kadam@intel.com>'
total: 8 errors, 10 warnings, 31 lines checked
parent reply other threads:[~2022-08-11 22:20 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220811221723.2124-1-pallavi.kadam@intel.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220811222053.94551120775@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=pallavi.kadam@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).