From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1F130A0540
	for <public@inbox.dpdk.org>; Fri, 12 Aug 2022 00:20:55 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 15085406A2;
	Fri, 12 Aug 2022 00:20:55 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id B673440697
 for <test-report@dpdk.org>; Fri, 12 Aug 2022 00:20:53 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 94551120775; Fri, 12 Aug 2022 00:20:53 +0200 (CEST)
Subject: |WARNING| pw114846 [dpdk-kmods v2] windows/netuio: fix BAR parsing
In-Reply-To: <20220811221723.2124-1-pallavi.kadam@intel.com>
References: <20220811221723.2124-1-pallavi.kadam@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Pallavi Kadam <pallavi.kadam@intel.com>
Message-Id: <20220811222053.94551120775@dpdk.org>
Date: Fri, 12 Aug 2022 00:20:53 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/114846

_coding style issues_


ERROR:CODE_INDENT: code indent should use tabs where possible
#115: FILE: windows/netuio/netuio_dev.c:196:
+        ULONG bar_value = pci_config.u.type0.BaseAddresses[bar_index];$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#115: FILE: windows/netuio/netuio_dev.c:196:
+        ULONG bar_value = pci_config.u.type0.BaseAddresses[bar_index];$

ERROR:CODE_INDENT: code indent should use tabs where possible
#117: FILE: windows/netuio/netuio_dev.c:198:
+        if (bar_value == 0) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#117: FILE: windows/netuio/netuio_dev.c:198:
+        if (bar_value == 0) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#117: FILE: windows/netuio/netuio_dev.c:198:
+        if (bar_value == 0) {
             continue;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#117: FILE: windows/netuio/netuio_dev.c:198:
+        if (bar_value == 0) {
             continue;
         }

ERROR:CODE_INDENT: code indent should use tabs where possible
#126: FILE: windows/netuio/netuio_dev.c:238:
+        // Skip the next BAR slot used by the current 64-bit address.$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#126: FILE: windows/netuio/netuio_dev.c:238:
+        // Skip the next BAR slot used by the current 64-bit address.$

ERROR:C99_COMMENTS: do not use C99 // comments
#126: FILE: windows/netuio/netuio_dev.c:238:
+        // Skip the next BAR slot used by the current 64-bit address.

ERROR:CODE_INDENT: code indent should use tabs where possible
#127: FILE: windows/netuio/netuio_dev.c:239:
+        if (bar_value & PCI_TYPE_64BIT) {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#127: FILE: windows/netuio/netuio_dev.c:239:
+        if (bar_value & PCI_TYPE_64BIT) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#127: FILE: windows/netuio/netuio_dev.c:239:
+        if (bar_value & PCI_TYPE_64BIT) {
+            bar_index++;

WARNING:BRACES: braces {} are not necessary for single statement blocks
#127: FILE: windows/netuio/netuio_dev.c:239:
+        if (bar_value & PCI_TYPE_64BIT) {
+            bar_index++;
+        }

ERROR:CODE_INDENT: code indent should use tabs where possible
#128: FILE: windows/netuio/netuio_dev.c:240:
+            bar_index++;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#128: FILE: windows/netuio/netuio_dev.c:240:
+            bar_index++;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#129: FILE: windows/netuio/netuio_dev.c:241:
+        }$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#129: FILE: windows/netuio/netuio_dev.c:241:
+        }$

ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Pallavi Kadam <pallavi.kadam@intel.com>'

total: 8 errors, 10 warnings, 31 lines checked