From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: longli@linuxonhyperv.com
Subject: |WARNING| pw115530 [Patch v5 01/18] net/mana: add basic driver, build environment and doc
Date: Sat, 27 Aug 2022 02:35:40 +0200 (CEST) [thread overview]
Message-ID: <20220827003540.38A6C121DAD@dpdk.org> (raw)
In-Reply-To: <1661560509-11009-2-git-send-email-longli@linuxonhyperv.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/115530
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#248: FILE: drivers/net/mana/mana.c:33:
+#define MKSTR(name, ...) \
+ int mkstr_size_##name = snprintf(NULL, 0, "" __VA_ARGS__); \
+ char name[mkstr_size_##name + 1]; \
+ \
+ memset(name, 0, mkstr_size_##name + 1); \
+ snprintf(name, sizeof(name), "" __VA_ARGS__)
WARNING:STATIC_CONST_CHAR_ARRAY: static const char * array should probably be static const char * const
#282: FILE: drivers/net/mana/mana.c:67:
+static const char *mana_init_args[] = {
CHECK:CAMELCASE: Avoid CamelCase: <SCNx32>
#426: FILE: drivers/net/mana/mana.c:211:
+ "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 "
",
CHECK:CAMELCASE: Avoid CamelCase: <SCNx8>
#426: FILE: drivers/net/mana/mana.c:211:
+ "%" SCNx32 ":%" SCNx8 ":%" SCNx8 ".%" SCNx8 "
",
total: 0 errors, 1 warnings, 3 checks, 1298 lines checked
parent reply other threads:[~2022-08-27 0:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1661560509-11009-2-git-send-email-longli@linuxonhyperv.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220827003540.38A6C121DAD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=longli@linuxonhyperv.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).