* |WARNING| pw115567 [PATCH 2/2] net/iavf: support inner and outer checksum offload
[not found] <20220812165223.470777-2-peng1x.zhang@intel.com>
2022-08-12 9:04 ` |SUCCESS| pw114859 [PATCH 2/2] net/iavf: support inner and outer checksum offload checkpatch
@ 2022-08-29 7:02 ` checkpatch
1 sibling, 0 replies; 2+ messages in thread
From: checkpatch @ 2022-08-29 7:02 UTC (permalink / raw)
To: test-report; +Cc: Buckley, Daniel M
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 3358 bytes --]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/115567
_coding style issues_
WARNING:BAD_SIGN_OFF: email address 'beilei.xing@intel.com, jingjing.wu@intel.com,' might be better as 'beilei.xing@intel.com,jingjing.wu@intel.com,'
#199:
Cc: beilei.xing@intel.com, jingjing.wu@intel.com,
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#299: FILE: drivers/net/iavf/iavf_rxtx.c:2421:
+ /* L4TUNLEN: L4 Tunneling Length, in Words
+ *
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#307: FILE: drivers/net/iavf/iavf_rxtx.c:2429:
+ */
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#311: FILE: drivers/net/iavf/iavf_rxtx.c:2433:
+ /**
+ * Calculate the tunneling UDP checksum.
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#313: FILE: drivers/net/iavf/iavf_rxtx.c:2435:
+ */
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#314: FILE: drivers/net/iavf/iavf_rxtx.c:2436:
+ if (!(eip_typ & IAVF_TX_CTX_EXT_IP_NONE) &&
[...]
+ eip_typ |= IAVF_TXD_CTX_QW0_L4T_CS_MASK;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#324: FILE: drivers/net/iavf/iavf_rxtx.c:2457:
if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK)
+ total_length -= m->outer_l3_len + m->outer_l2_len;
WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#326: FILE: drivers/net/iavf/iavf_rxtx.c:2458:
+ total_length -= m->outer_l3_len + m->outer_l2_len;
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#336: FILE: drivers/net/iavf/iavf_rxtx.c:2576:
+ if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK)
+ offset |= (m->outer_l2_len >> 1)
CHECK:SPACING: spaces preferred around that '<<' (ctx:VxW)
#338: FILE: drivers/net/iavf/iavf_rxtx.c:2578:
+ << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
^
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#339: FILE: drivers/net/iavf/iavf_rxtx.c:2579:
+ else
[...]
+ << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
CHECK:SPACING: spaces preferred around that '<<' (ctx:VxW)
#341: FILE: drivers/net/iavf/iavf_rxtx.c:2581:
+ << IAVF_TX_DESC_LENGTH_MACLEN_SHIFT;
^
CHECK:SPACING: spaces preferred around that '|' (ctx:WxV)
#355: FILE: drivers/net/iavf/iavf_rxtx.h:30:
+ RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM | \
^
CHECK:SPACING: spaces preferred around that '|' (ctx:WxV)
#373: FILE: drivers/net/iavf/iavf_rxtx.h:73:
+ RTE_MBUF_F_TX_TUNNEL_MASK | \
^
total: 0 errors, 10 warnings, 4 checks, 110 lines checked
^ permalink raw reply [flat|nested] 2+ messages in thread