From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Buckley, Daniel M" <daniel.m.buckley@intel.com>
Subject: |WARNING| pw115566 [PATCH 1/2] net/iavf: enable TSO offloading for tunnel cases
Date: Mon, 29 Aug 2022 09:02:43 +0200 (CEST) [thread overview]
Message-ID: <20220829070243.43445121DAD@dpdk.org> (raw)
In-Reply-To: <20220812165223.470777-1-peng1x.zhang@intel.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 4975 bytes --]
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/115566
_coding style issues_
WARNING:BAD_SIGN_OFF: email address 'beilei.xing@intel.com, jingjing.wu@intel.com,' might be better as 'beilei.xing@intel.com,jingjing.wu@intel.com,'
#199:
Cc: beilei.xing@intel.com, jingjing.wu@intel.com,
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#256: FILE: drivers/net/iavf/iavf_rxtx.c:2646:
+#define IAVF_MAX_DATA_PER_TXD \
+ (IAVF_TXD_QW1_TX_BUF_SZ_MASK >> IAVF_TXD_QW1_TX_BUF_SZ_SHIFT)
WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#261: FILE: drivers/net/iavf/iavf_rxtx.c:2651:
+ volatile uint64_t desc_template, struct iavf_tx_entry *txe,
WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#262: FILE: drivers/net/iavf/iavf_rxtx.c:2652:
+ volatile struct iavf_tx_desc *txr, struct iavf_tx_entry *txe_ring,
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#271: FILE: drivers/net/iavf/iavf_rxtx.c:2661:
+ while ((m->ol_flags & RTE_MBUF_F_TX_TCP_SEG) &&
[...]
+ txd->buffer_addr = rte_cpu_to_le_64(buf_dma_addr);
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#273: FILE: drivers/net/iavf/iavf_rxtx.c:2663:
+ txd->buffer_addr = rte_cpu_to_le_64(buf_dma_addr);
WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#278: FILE: drivers/net/iavf/iavf_rxtx.c:2668:
+ IAVF_TXD_DATA_QW1_TX_BUF_SZ_SHIFT) | desc_template;
WARNING:LONG_LINE: line length of 122 exceeds 100 columns
#292: FILE: drivers/net/iavf/iavf_rxtx.c:2682:
+ rte_cpu_to_le_64((uint64_t)slen << IAVF_TXD_DATA_QW1_TX_BUF_SZ_SHIFT) |
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#323: FILE: drivers/net/iavf/iavf_rxtx.c:2835:
+ if (nb_desc_ipsec) {
+ iavf_fill_data_desc(ddesc, mb_seg,
WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#324: FILE: drivers/net/iavf/iavf_rxtx.c:2836:
+ iavf_fill_data_desc(ddesc, mb_seg,
WARNING:LONG_LINE: line length of 119 exceeds 100 columns
#325: FILE: drivers/net/iavf/iavf_rxtx.c:2837:
+ ddesc_template, tlen, ipseclen);
WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#326: FILE: drivers/net/iavf/iavf_rxtx.c:2838:
+ IAVF_DUMP_TX_DESC(txq, ddesc, desc_idx);
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#327: FILE: drivers/net/iavf/iavf_rxtx.c:2839:
+ } else {
+ iavf_fill_unencrypt_desc(txd, mb_seg,
WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#328: FILE: drivers/net/iavf/iavf_rxtx.c:2840:
+ iavf_fill_unencrypt_desc(txd, mb_seg,
WARNING:LONG_LINE: line length of 138 exceeds 100 columns
#329: FILE: drivers/net/iavf/iavf_rxtx.c:2841:
+ ddesc_template, txe, txr, txe_ring, desc_idx_last);
WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#330: FILE: drivers/net/iavf/iavf_rxtx.c:2842:
+ IAVF_DUMP_TX_DESC(txq, txd, desc_idx);
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#340: FILE: drivers/net/iavf/iavf_rxtx.c:2868:
+ if (nb_desc_ipsec) {
+ ddesc->cmd_type_offset_bsz |= rte_cpu_to_le_64(ddesc_cmd <<
WARNING:LONG_LINE: line length of 110 exceeds 100 columns
#341: FILE: drivers/net/iavf/iavf_rxtx.c:2869:
+ ddesc->cmd_type_offset_bsz |= rte_cpu_to_le_64(ddesc_cmd <<
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#346: FILE: drivers/net/iavf/iavf_rxtx.c:2872:
+ } else {
+ txd->cmd_type_offset_bsz |= rte_cpu_to_le_64(ddesc_cmd <<
WARNING:LONG_LINE: line length of 108 exceeds 100 columns
#347: FILE: drivers/net/iavf/iavf_rxtx.c:2873:
+ txd->cmd_type_offset_bsz |= rte_cpu_to_le_64(ddesc_cmd <<
total: 1 errors, 19 warnings, 0 checks, 98 lines checked
prev parent reply other threads:[~2022-08-29 7:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220812165223.470777-1-peng1x.zhang@intel.com>
2022-08-12 9:02 ` |SUCCESS| pw114858 " checkpatch
2022-08-29 7:02 ` checkpatch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220829070243.43445121DAD@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=daniel.m.buckley@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).