* |WARNING| pw116666 [v1 02/19] net/mlx5: split flow item matcher and value translation
[not found] <20220922190345.394-3-valex@nvidia.com>
@ 2022-09-22 19:05 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2022-09-22 19:05 UTC (permalink / raw)
To: test-report; +Cc: Alex Vesker
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/116666
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects?
#183: FILE: drivers/net/mlx5/mlx5_flow_dv.c:66:
+#define MLX5_ITEM_VALID(item, key_type) \
+ (((MLX5_SET_MATCHER_SW & (key_type)) && !((item)->spec)) || \
+ ((MLX5_SET_MATCHER_HS_V == (key_type)) && !((item)->spec)) || \
+ ((MLX5_SET_MATCHER_HS_M == (key_type)) && !((item)->mask)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'key_type' - possible side-effects?
#183: FILE: drivers/net/mlx5/mlx5_flow_dv.c:66:
+#define MLX5_ITEM_VALID(item, key_type) \
+ (((MLX5_SET_MATCHER_SW & (key_type)) && !((item)->spec)) || \
+ ((MLX5_SET_MATCHER_HS_V == (key_type)) && !((item)->spec)) || \
+ ((MLX5_SET_MATCHER_HS_M == (key_type)) && !((item)->mask)))
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'item' - possible side-effects?
#188: FILE: drivers/net/mlx5/mlx5_flow_dv.c:71:
+#define MLX5_ITEM_UPDATE(item, key_type, v, m, gm) \
+ do { \
+ if ((key_type) == MLX5_SET_MATCHER_SW_V) { \
+ v = (item)->spec; \
+ m = (item)->mask ? (item)->mask : (gm); \
+ } else if ((key_type) == MLX5_SET_MATCHER_HS_V) { \
+ v = (item)->spec; \
+ m = (v); \
+ } else { \
+ v = (item)->mask ? (item)->mask : (gm); \
+ m = (v); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'key_type' - possible side-effects?
#188: FILE: drivers/net/mlx5/mlx5_flow_dv.c:71:
+#define MLX5_ITEM_UPDATE(item, key_type, v, m, gm) \
+ do { \
+ if ((key_type) == MLX5_SET_MATCHER_SW_V) { \
+ v = (item)->spec; \
+ m = (item)->mask ? (item)->mask : (gm); \
+ } else if ((key_type) == MLX5_SET_MATCHER_HS_V) { \
+ v = (item)->spec; \
+ m = (v); \
+ } else { \
+ v = (item)->mask ? (item)->mask : (gm); \
+ m = (v); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'v' - possible side-effects?
#188: FILE: drivers/net/mlx5/mlx5_flow_dv.c:71:
+#define MLX5_ITEM_UPDATE(item, key_type, v, m, gm) \
+ do { \
+ if ((key_type) == MLX5_SET_MATCHER_SW_V) { \
+ v = (item)->spec; \
+ m = (item)->mask ? (item)->mask : (gm); \
+ } else if ((key_type) == MLX5_SET_MATCHER_HS_V) { \
+ v = (item)->spec; \
+ m = (v); \
+ } else { \
+ v = (item)->mask ? (item)->mask : (gm); \
+ m = (v); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'm' - possible side-effects?
#188: FILE: drivers/net/mlx5/mlx5_flow_dv.c:71:
+#define MLX5_ITEM_UPDATE(item, key_type, v, m, gm) \
+ do { \
+ if ((key_type) == MLX5_SET_MATCHER_SW_V) { \
+ v = (item)->spec; \
+ m = (item)->mask ? (item)->mask : (gm); \
+ } else if ((key_type) == MLX5_SET_MATCHER_HS_V) { \
+ v = (item)->spec; \
+ m = (v); \
+ } else { \
+ v = (item)->mask ? (item)->mask : (gm); \
+ m = (v); \
+ } \
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'gm' - possible side-effects?
#188: FILE: drivers/net/mlx5/mlx5_flow_dv.c:71:
+#define MLX5_ITEM_UPDATE(item, key_type, v, m, gm) \
+ do { \
+ if ((key_type) == MLX5_SET_MATCHER_SW_V) { \
+ v = (item)->spec; \
+ m = (item)->mask ? (item)->mask : (gm); \
+ } else if ((key_type) == MLX5_SET_MATCHER_HS_V) { \
+ v = (item)->spec; \
+ m = (v); \
+ } else { \
+ v = (item)->mask ? (item)->mask : (gm); \
+ m = (v); \
+ } \
+ } while (0)
total: 0 errors, 0 warnings, 7 checks, 3615 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-09-22 19:05 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220922190345.394-3-valex@nvidia.com>
2022-09-22 19:05 ` |WARNING| pw116666 [v1 02/19] net/mlx5: split flow item matcher and value translation checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).