From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F1FCA0544 for ; Thu, 22 Sep 2022 21:09:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BBDF40150; Thu, 22 Sep 2022 21:09:04 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id E5123400D7 for ; Thu, 22 Sep 2022 21:09:02 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id DED65121F02; Thu, 22 Sep 2022 21:09:02 +0200 (CEST) Subject: |WARNING| pw116674 [v1 11/19] net/mlx5/hws: Add HWS send layer In-Reply-To: <20220922190345.394-12-valex@nvidia.com> References: <20220922190345.394-12-valex@nvidia.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Alex Vesker Message-Id: <20220922190902.DED65121F02@dpdk.org> Date: Thu, 22 Sep 2022 21:09:02 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/116674 _coding style issues_ WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns #143: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:2: + * Copyright (c) Copyright (c) 2022 NVIDIA Corporation 2021 NVIDIA CORPORATION. All rights reserved. Affiliates WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #152: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:11: + unsigned idx = send_sq->head_dep_idx++ & (queue->num_entries - 1); ERROR:C99_COMMENTS: do not use C99 // comments #208: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:67: + ctrl.send_ring = &queue->send_ring[0]; // TODO: Change when send rings > 1 WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #267: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:126: + unsigned idx; CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around cq->ncqe_mask #517: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:376: + uint32_t cq_idx = cq->cons_index & (cq->ncqe_mask); WARNING:LONG_LINE: line length of 109 exceeds 100 columns #567: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:426: + *queue->send_ring[j].send_cq.db = htobe32(queue->send_ring[j].send_cq.cons_index & 0xffffff); ERROR:CODE_INDENT: code indent should use tabs where possible #587: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:446: + } else {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #587: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:446: + } else {$ ERROR:CODE_INDENT: code indent should use tabs where possible #654: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:513: + return (val + align - 1) & ~(align - 1);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #654: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:513: + return (val + align - 1) & ~(align - 1);$ ERROR:SPACING: space prohibited before that ',' (ctx:WxV) #709: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:568: + sq->dep_wqe = simple_calloc(queue->num_entries ,sizeof(*sq->dep_wqe)); ^ ERROR:SPACING: space required after that ',' (ctx:WxV) #709: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:568: + sq->dep_wqe = simple_calloc(queue->num_entries ,sizeof(*sq->dep_wqe)); ^ ERROR:CODE_INDENT: code indent should use tabs where possible #784: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:643: + cq->cqn = mlx5_cq.cqn;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #784: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:643: + cq->cqn = mlx5_cq.cqn;$ ERROR:CODE_INDENT: code indent should use tabs where possible #787: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:646: + return 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #787: FILE: drivers/net/mlx5/hws/mlx5dr_send.c:646: + return 0;$ WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns #998: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:2: + * Copyright (c) Copyright (c) 2022 NVIDIA Corporation 2021 NVIDIA CORPORATION. All rights reserved. Affiliates ERROR:CODE_INDENT: code indent should use tabs where possible #1013: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:17: + __be32 opmod_idx_opcode;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1013: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:17: + __be32 opmod_idx_opcode;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1014: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:18: + __be32 qpn_ds;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1014: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:18: + __be32 qpn_ds;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1015: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:19: + __be32 flags;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1015: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:19: + __be32 flags;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1016: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:20: + __be32 imm;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1016: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:20: + __be32 imm;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1069: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:73: + uint8_t *buf;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1069: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:73: + uint8_t *buf;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1070: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:74: + uint32_t cons_index;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1070: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:74: + uint32_t cons_index;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1073: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:77: + uint32_t ncqe;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1073: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:77: + uint32_t ncqe;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1075: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:79: + __be32 *db;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1075: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:79: + __be32 *db;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1077: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:81: + struct ibv_cq *ibv_cq;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1077: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:81: + struct ibv_cq *ibv_cq;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1078: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:82: + uint32_t cqn;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1078: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:82: + uint32_t cqn;$ ERROR:CODE_INDENT: code indent should use tabs where possible #1079: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:83: + uint32_t cqe_sz;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #1079: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:83: + uint32_t cqe_sz;$ WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1110: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:114: + unsigned last_idx; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1112: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:116: + unsigned head_dep_idx; WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned' #1113: FILE: drivers/net/mlx5/hws/mlx5dr_send.h:117: + unsigned tail_dep_idx; total: 18 errors, 23 warnings, 1 checks, 1122 lines checked