From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Alex Vesker <valex@nvidia.com>
Subject: |WARNING| pw116673 [v1 10/19] net/mlx5/hws: Add HWS pool and buddy
Date: Thu, 22 Sep 2022 21:09:10 +0200 (CEST) [thread overview]
Message-ID: <20220922190910.C4EFA121F02@dpdk.org> (raw)
In-Reply-To: <20220922190345.394-11-valex@nvidia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/116673
_coding style issues_
CHECK:SPACING: No space is necessary after a cast
#240: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:97:
+ for (i = 0; i <= (int) buddy->max_order; ++i) {
CHECK:SPACING: No space is necessary after a cast
#254: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:111:
+ for (i = 0; i <= (int) buddy->max_order; ++i)
CHECK:SPACING: No space is necessary after a cast
#288: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:145:
+ for (i = 0; i <= (int) buddy->max_order; ++i) {
WARNING:BRACES: braces {} are not necessary for single statement blocks
#288: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:145:
+ for (i = 0; i <= (int) buddy->max_order; ++i) {
+ rte_free(buddy->bits[i]);
+ }
CHECK:SPACING: No space is necessary after a cast
#301: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:158:
+ for (o = order; o <= (int) buddy->max_order; ++o)
WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#352: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.h:2:
+ * Copyright (c) Copyright (c) 2022 NVIDIA Corporation 2021 NVIDIA CORPORATION. All rights reserved. Affiliates
WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#376: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:2:
+ * Copyright (c) Copyright (c) 2022 NVIDIA Corporation 2021 NVIDIA CORPORATION. All rights reserved. Affiliates
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#491: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:117:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#742: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:368:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#764: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:390:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#772: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:398:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#795: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:421:
+ return ENOMEM;
WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#799: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:425:
+ return ENOMEM;
WARNING:TYPO_SPELLING: 'elemnt' may be misspelled - perhaps 'element'?
#843: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:469:
+ DR_LOG(ERR, "No mem for general elemnt_manager");
WARNING:TYPO_SPELLING: 'elemnt' may be misspelled - perhaps 'element'?
#933: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:559:
+ DR_LOG(ERR, "No mem for general elemnt_manager");
WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#1054: FILE: drivers/net/mlx5/hws/mlx5dr_pool.h:2:
+ * Copyright (c) Copyright (c) 2022 NVIDIA Corporation 2021 NVIDIA CORPORATION. All rights reserved. Affiliates
total: 0 errors, 12 warnings, 4 checks, 1043 lines checked
Warning in drivers/net/mlx5/hws/mlx5dr_buddy.c:
Using %l format, prefer %PRI*64 if type is [u]int64_t
parent reply other threads:[~2022-09-22 19:09 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220922190345.394-11-valex@nvidia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220922190910.C4EFA121F02@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=valex@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).