automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Alex Vesker <valex@nvidia.com>
Subject: |WARNING| pw116682 [v1 19/19] net/mlx5/hws: Enable HWS
Date: Thu, 22 Sep 2022 21:11:23 +0200 (CEST)	[thread overview]
Message-ID: <20220922191123.27129121F02@dpdk.org> (raw)
In-Reply-To: <20220922190345.394-20-valex@nvidia.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/116682

_coding style issues_


WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#168: FILE: drivers/net/mlx5/hws/mlx5dr.h:2:
+ * Copyright (c) Copyright (c) 2022 NVIDIA Corporation 2021 NVIDIA CORPORATION. All rights reserved. Affiliates

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#680: FILE: drivers/net/mlx5/hws/mlx5dr.h:514:
+ * ^ICopy the ASO object value into this reg_id, after a packet hits a rule with this ASO object.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#739: FILE: drivers/net/mlx5/hws/mlx5dr.h:573:
+ * ^IThe context to which the queue belong to.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#741: FILE: drivers/net/mlx5/hws/mlx5dr.h:575:
+ * ^IThe id of the queue to perform the action on.$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#743: FILE: drivers/net/mlx5/hws/mlx5dr.h:577:
+ * ^IActions to perform on the queue. (enum mlx5dr_send_queue_actions)$

WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#755: FILE: drivers/net/mlx5/hws/mlx5dr.h:589:
+ * ^IThe file to write the dump to.$

WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#768: FILE: drivers/net/mlx5/hws/mlx5dr_internal.h:2:
+ * Copyright (c) Copyright (c) 2022 NVIDIA Corporation 2021 NVIDIA CORPORATION. All rights reserved. Affiliates

CHECK:MACRO_ARG_PRECEDENCE: Macro argument '_value' may be better as '(_value)' to avoid precedence issues
#812: FILE: drivers/net/mlx5/hws/mlx5dr_internal.h:46:
+#define IS_BIT_SET(_value, _bit) (_value & (1ULL << (_bit)))

WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#824: FILE: drivers/net/mlx5/hws/mlx5dr_internal.h:58:
+	DRV_LOG(level, RTE_FMT("[%s]: " RTE_FMT_HEAD(__VA_ARGS__,), __func__, RTE_FMT_TAIL(__VA_ARGS__,)))

ERROR:SPACING: space required after that ',' (ctx:VxB)
#824: FILE: drivers/net/mlx5/hws/mlx5dr_internal.h:58:
+	DRV_LOG(level, RTE_FMT("[%s]: " RTE_FMT_HEAD(__VA_ARGS__,), __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
 	                                                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#824: FILE: drivers/net/mlx5/hws/mlx5dr_internal.h:58:
+	DRV_LOG(level, RTE_FMT("[%s]: " RTE_FMT_HEAD(__VA_ARGS__,), __func__, RTE_FMT_TAIL(__VA_ARGS__,)))
 	                                                                                              ^

total: 2 errors, 8 warnings, 1 checks, 740 lines checked

           reply	other threads:[~2022-09-22 19:11 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20220922190345.394-20-valex@nvidia.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220922191123.27129121F02@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=test-report@dpdk.org \
    --cc=valex@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).