From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Akhil Goyal <gakhil@marvell.com>
Subject: |WARNING| pw117056 [PATCH 4/5] test/security: add inline MACsec cases
Date: Wed, 28 Sep 2022 14:48:18 +0200 (CEST) [thread overview]
Message-ID: <20220928124818.2797112231E@dpdk.org> (raw)
In-Reply-To: <20220928124516.93050-5-gakhil@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117056
_coding style issues_
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#303: FILE: app/test/test_security_inline_macsec.c:193:
+ * from the test vector so that we can match the out packet. */
ERROR:C99_COMMENTS: do not use C99 // comments
#357: FILE: app/test/test_security_inline_macsec.c:247:
+// struct rte_security_capability_idx sec_cap_idx;
ERROR:C99_COMMENTS: do not use C99 // comments
#358: FILE: app/test/test_security_inline_macsec.c:248:
+// const struct rte_security_capability *sec_cap;
ERROR:C99_COMMENTS: do not use C99 // comments
#392: FILE: app/test/test_security_inline_macsec.c:282:
+// sec_cap = rte_security_capability_get(sec_ctx, &sec_cap_idx);
ERROR:C99_COMMENTS: do not use C99 // comments
#393: FILE: app/test/test_security_inline_macsec.c:283:
+// if (sec_cap == NULL) {
ERROR:C99_COMMENTS: do not use C99 // comments
#394: FILE: app/test/test_security_inline_macsec.c:284:
+// printf("No capabilities registered
");
ERROR:C99_COMMENTS: do not use C99 // comments
#395: FILE: app/test/test_security_inline_macsec.c:285:
+// return TEST_SKIPPED;
ERROR:C99_COMMENTS: do not use C99 // comments
#396: FILE: app/test/test_security_inline_macsec.c:286:
+// }
total: 7 errors, 1 warnings, 3146 lines checked
Warning in app/test/test_security_inline_macsec.c:
Declaring a variable inside for()
parent reply other threads:[~2022-09-28 12:48 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220928124516.93050-5-gakhil@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928124818.2797112231E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=gakhil@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).