From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Akhil Goyal <gakhil@marvell.com>
Subject: |WARNING| pw117055 [PATCH 3/5] net/cnxk: support MACsec
Date: Wed, 28 Sep 2022 14:48:24 +0200 (CEST) [thread overview]
Message-ID: <20220928124824.6DF6E12231E@dpdk.org> (raw)
In-Reply-To: <20220928124516.93050-4-gakhil@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117055
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
ERROR:SPACING: space prohibited before that ':' (ctx:WxE)
#142: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:41:
+ default :
^
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#393: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:292:
+ ret = mcs_resource_alloc(mcs_dev, sess->dir, &(sess->flow_id), 1, CNXK_MCS_RSRC_TYPE_FLOWID);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around sess->flow_id
#393: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:292:
+ ret = mcs_resource_alloc(mcs_dev, sess->dir, &(sess->flow_id), 1, CNXK_MCS_RSRC_TYPE_FLOWID);
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#421: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:320:
+ req.data[0] = (uint64_t)dst.addr_bytes[0] << 40 | (uint64_t)dst.addr_bytes[1] << 32 |
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#422: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:321:
+ (uint64_t)dst.addr_bytes[2] << 24 | (uint64_t)dst.addr_bytes[3] << 16 |
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#426: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:325:
+ (uint64_t)src.addr_bytes[1] << 16 | (uint64_t)src.addr_bytes[0] << 24 |
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#439: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:338:
+ ((uint64_t)opts.num_tags & 0x7F) << 2 | ((uint64_t)opts.express & 1) << 9 |
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#693: FILE: drivers/net/cnxk/cnxk_ethdev.h:671:
+struct cnxk_mcs_dev * cnxk_mcs_dev_init(uint8_t mcs_idx);
total: 2 errors, 6 warnings, 1 checks, 594 lines checked
parent reply other threads:[~2022-09-28 12:48 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20220928124516.93050-4-gakhil@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928124824.6DF6E12231E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=gakhil@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).