From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 48DB8A00C4
	for <public@inbox.dpdk.org>; Wed, 28 Sep 2022 14:48:26 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 440E84113D;
	Wed, 28 Sep 2022 14:48:26 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 73A334113C
 for <test-report@dpdk.org>; Wed, 28 Sep 2022 14:48:24 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 6DF6E12231E; Wed, 28 Sep 2022 14:48:24 +0200 (CEST)
Subject: |WARNING| pw117055 [PATCH 3/5] net/cnxk: support MACsec
In-Reply-To: <20220928124516.93050-4-gakhil@marvell.com>
References: <20220928124516.93050-4-gakhil@marvell.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Akhil Goyal <gakhil@marvell.com>
Message-Id: <20220928124824.6DF6E12231E@dpdk.org>
Date: Wed, 28 Sep 2022 14:48:24 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117055

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

ERROR:SPACING: space prohibited before that ':' (ctx:WxE)
#142: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:41:
+		default :
 		        ^

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#393: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:292:
+	ret = mcs_resource_alloc(mcs_dev, sess->dir, &(sess->flow_id), 1, CNXK_MCS_RSRC_TYPE_FLOWID);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around sess->flow_id
#393: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:292:
+	ret = mcs_resource_alloc(mcs_dev, sess->dir, &(sess->flow_id), 1, CNXK_MCS_RSRC_TYPE_FLOWID);

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#421: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:320:
+		req.data[0] = (uint64_t)dst.addr_bytes[0] << 40 | (uint64_t)dst.addr_bytes[1] << 32 |

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#422: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:321:
+			      (uint64_t)dst.addr_bytes[2] << 24 | (uint64_t)dst.addr_bytes[3] << 16 |

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#426: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:325:
+			      (uint64_t)src.addr_bytes[1] << 16 | (uint64_t)src.addr_bytes[0] << 24 |

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#439: FILE: drivers/net/cnxk/cn10k_ethdev_mcs.c:338:
+			      ((uint64_t)opts.num_tags & 0x7F) << 2 | ((uint64_t)opts.express & 1) << 9 |

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#693: FILE: drivers/net/cnxk/cnxk_ethdev.h:671:
+struct cnxk_mcs_dev * cnxk_mcs_dev_init(uint8_t mcs_idx);

total: 2 errors, 6 warnings, 1 checks, 594 lines checked