From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "jiangheng (G)" <jiangheng14@huawei.com>
Subject: |WARNING| pw117061 [PATCH] TCP data length is incorrectly calculated in the gro_tcp4_reassemble function.
Date: Wed, 28 Sep 2022 16:12:31 +0200 (CEST) [thread overview]
Message-ID: <20220928141231.65F4812231E@dpdk.org> (raw)
In-Reply-To: <1c1df455cdb640c9889d359186d38637@huawei.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117061
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#68:
if packets < 60 bytes, pkt_len will contain padding bytes, tcp_dl is incorrectly calculated. this will result the wrong data length after gro.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#79: FILE: lib/gro/gro_tcp4.c:232:
+ tcp_dl = rte_be_to_cpu_16(ipv4_hdr->total_length) - hdr_len;$
ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)
total: 1 errors, 2 warnings, 8 lines checked
next parent reply other threads:[~2022-09-28 14:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1c1df455cdb640c9889d359186d38637@huawei.com>
2022-09-28 14:12 ` checkpatch [this message]
2022-09-28 14:29 dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220928141231.65F4812231E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=jiangheng14@huawei.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).