|WARNING| pw117061 [PATCH] TCP data length is incorrectly calculated in the gro_tcp4_reassemble function.

|WARNING| pw117061 [PATCH] TCP data length is incorrectly calculated in the gro_tcp4_reassemble function.

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117061

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#68: 
if packets < 60 bytes, pkt_len will contain padding bytes, tcp_dl is incorrectly calculated. this will result the wrong data length after gro.

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#79: FILE: lib/gro/gro_tcp4.c:232:
+       tcp_dl = rte_be_to_cpu_16(ipv4_hdr->total_length) - hdr_len;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 1 errors, 2 warnings, 8 lines checked

|WARNING| pw117061 [PATCH] TCP data length is incorrectly calculated in the gro_tcp4_reassemble function.

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 1144 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/117061

_apply patch failure_

Submitter: jiangheng (G) <jiangheng14@huawei.com>
Date: Wednesday, September 28 2022 14:10:52 
Applied on: CommitID:3fe71706abc1f13294c82477a0538047f8e4ebbf
Apply patch set 117061 failed:

Checking patch lib/gro/gro_tcp4.c...
error: while searching for:
        * Don't process the packet whose payload length is less than or
        * equal to 0.
        */
       tcp_dl = pkt->pkt_len - hdr_len;
       if (tcp_dl <= 0)
               return -1;


error: patch failed: lib/gro/gro_tcp4.c:229
Applying patch lib/gro/gro_tcp4.c with 1 reject...
Rejected hunk #1.
diff a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c	(rejected hunks)
@@ -229,7 +229,7 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
         * Don't process the packet whose payload length is less than or
         * equal to 0.
         */
-       tcp_dl = pkt->pkt_len - hdr_len;
+       tcp_dl = rte_be_to_cpu_16(ipv4_hdr->total_length) - hdr_len;
        if (tcp_dl <= 0)
                return -1;


https://lab.dpdk.org/results/dashboard/patchsets/23681/

UNH-IOL DPDK Community Lab