From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CCE82A00C2
	for <public@inbox.dpdk.org>; Thu,  6 Oct 2022 17:09:44 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C9F9542C9E;
	Thu,  6 Oct 2022 17:09:44 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 61AF742C9D
 for <test-report@dpdk.org>; Thu,  6 Oct 2022 17:09:44 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 5DBC0120EFA; Thu,  6 Oct 2022 17:09:44 +0200 (CEST)
Subject: |WARNING| pw117470 [v2 10/19] net/mlx5/hws: Add HWS pool and buddy
In-Reply-To: <20221006150325.660-11-valex@nvidia.com>
References: <20221006150325.660-11-valex@nvidia.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Alex Vesker <valex@nvidia.com>
Message-Id: <20221006150944.5DBC0120EFA@dpdk.org>
Date: Thu,  6 Oct 2022 17:09:44 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117470

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#211: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:67:
+		DR_LOG(ERR, "Unexpected bit (%d < %"PRIx64") from bitmap", pos, n);

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#211: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:67:
+		DR_LOG(ERR, "Unexpected bit (%d < %"PRIx64") from bitmap", pos, n);

WARNING:BRACES: braces {} are not necessary for single statement blocks
#289: FILE: drivers/net/mlx5/hws/mlx5dr_buddy.c:145:
+	for (i = 0; i <= (int)buddy->max_order; ++i) {
+		rte_free(buddy->bits[i]);
+	}

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#496: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:117:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#747: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:368:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#769: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:390:
+		return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#777: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:398:
+	return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#800: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:421:
+	return ENOMEM;

WARNING:USE_NEGATIVE_ERRNO: return of an errno should typically be negative (ie: return -ENOMEM)
#804: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:425:
+	return ENOMEM;

WARNING:TYPO_SPELLING: 'elemnt' may be misspelled - perhaps 'element'?
#848: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:469:
+		DR_LOG(ERR, "No mem for general elemnt_manager");

WARNING:TYPO_SPELLING: 'elemnt' may be misspelled - perhaps 'element'?
#938: FILE: drivers/net/mlx5/hws/mlx5dr_pool.c:559:
+		DR_LOG(ERR, "No mem for general elemnt_manager");

total: 0 errors, 9 warnings, 2 checks, 1047 lines checked