From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: "Morten Brørup" <mb@smartsharesystems.com>
Subject: |WARNING| pw117504 [PATCH] eal: non-temporal memcpy
Date: Thu, 6 Oct 2022 22:35:45 +0200 (CEST) [thread overview]
Message-ID: <20221006203545.ABC64120EFA@dpdk.org> (raw)
In-Reply-To: <20221006203426.78743-1-mb@smartsharesystems.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117504
_coding style issues_
ERROR:TRAILING_WHITESPACE: trailing whitespace
#135: FILE: app/test/test_memcpy.c:46:
+const char * const nt_mode_str[4] = { $
ERROR:CODE_INDENT: code indent should use tabs where possible
#242: FILE: app/test/test_memcpy.c:140:
+^I^I^I^I^I buf_sizes[i], nt_mode);$
WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#275: FILE: app/test/test_memcpy_perf.c:33:
+ 127, 128, 129, 140, 152, 191, 192, 193, 255, 256, 257, 319, 320, 321, 383, 384, 385, 447, 448,
ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop
#284: FILE: app/test/test_memcpy_perf.c:66:
+#define ALIGNED_FLAGS ((ALIGNMENT_UNIT << RTE_MEMOPS_F_SRCA_SHIFT) | \
+ (ALIGNMENT_UNIT << RTE_MEMOPS_F_DSTA_SHIFT);
WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#284: FILE: app/test/test_memcpy_perf.c:66:
+#define ALIGNED_FLAGS ((ALIGNMENT_UNIT << RTE_MEMOPS_F_SRCA_SHIFT) | \
+ (ALIGNMENT_UNIT << RTE_MEMOPS_F_DSTA_SHIFT);
ERROR:CODE_INDENT: code indent should use tabs where possible
#285: FILE: app/test/test_memcpy_perf.c:67:
+ (ALIGNMENT_UNIT << RTE_MEMOPS_F_DSTA_SHIFT);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#285: FILE: app/test/test_memcpy_perf.c:67:
+ (ALIGNMENT_UNIT << RTE_MEMOPS_F_DSTA_SHIFT);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#296: FILE: app/test/test_memcpy_perf.c:181:
+ uint64_t start_time; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#297: FILE: app/test/test_memcpy_perf.c:182:
+ uint64_t total_time_rte = 0, total_time_std = 0; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#298: FILE: app/test/test_memcpy_perf.c:183:
+ uint64_t total_time_ntd = 0, total_time_nts = 0, total_time_nt = 0; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#299: FILE: app/test/test_memcpy_perf.c:184:
+ const uint64_t flags = ((dst_uoffset == 0) ? \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#300: FILE: app/test/test_memcpy_perf.c:185:
+ (ALIGNMENT_UNIT << RTE_MEMOPS_F_DSTA_SHIFT) : 0) | \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#300: FILE: app/test/test_memcpy_perf.c:185:
+ (ALIGNMENT_UNIT << RTE_MEMOPS_F_DSTA_SHIFT) : 0) | \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#301: FILE: app/test/test_memcpy_perf.c:186:
+ ((src_uoffset == 0) ? \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#301: FILE: app/test/test_memcpy_perf.c:186:
+ ((src_uoffset == 0) ? \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#302: FILE: app/test/test_memcpy_perf.c:187:
+ (ALIGNMENT_UNIT << RTE_MEMOPS_F_SRCA_SHIFT) : 0); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#302: FILE: app/test/test_memcpy_perf.c:187:
+ (ALIGNMENT_UNIT << RTE_MEMOPS_F_SRCA_SHIFT) : 0); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#310: FILE: app/test/test_memcpy_perf.c:194:
+ total_time_rte += rte_rdtsc() - start_time; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#310: FILE: app/test/test_memcpy_perf.c:194:
+ total_time_rte += rte_rdtsc() - start_time; \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#319: FILE: app/test/test_memcpy_perf.c:202:
+ total_time_std += rte_rdtsc() - start_time; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#319: FILE: app/test/test_memcpy_perf.c:202:
+ total_time_std += rte_rdtsc() - start_time; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#324: FILE: app/test/test_memcpy_perf.c:204:
+ if (!(is_dst_cached && is_src_cached)) { \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#325: FILE: app/test/test_memcpy_perf.c:205:
+ for (iter = 0; iter < (TEST_ITERATIONS / TEST_BATCH_SIZE); iter++) { \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#325: FILE: app/test/test_memcpy_perf.c:205:
+ for (iter = 0; iter < (TEST_ITERATIONS / TEST_BATCH_SIZE); iter++) { \$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#325: FILE: app/test/test_memcpy_perf.c:205:
+ for (iter = 0; iter < (TEST_ITERATIONS / TEST_BATCH_SIZE); iter++) { \
+ fill_addr_arrays(dst_addrs, is_dst_cached, dst_uoffset, \
ERROR:CODE_INDENT: code indent should use tabs where possible
#326: FILE: app/test/test_memcpy_perf.c:206:
+ fill_addr_arrays(dst_addrs, is_dst_cached, dst_uoffset, \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#326: FILE: app/test/test_memcpy_perf.c:206:
+ fill_addr_arrays(dst_addrs, is_dst_cached, dst_uoffset, \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#327: FILE: app/test/test_memcpy_perf.c:207:
+ src_addrs, is_src_cached, src_uoffset); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#327: FILE: app/test/test_memcpy_perf.c:207:
+ src_addrs, is_src_cached, src_uoffset); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#328: FILE: app/test/test_memcpy_perf.c:208:
+ start_time = rte_rdtsc(); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#328: FILE: app/test/test_memcpy_perf.c:208:
+ start_time = rte_rdtsc(); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#329: FILE: app/test/test_memcpy_perf.c:209:
+ for (t = 0; t < TEST_BATCH_SIZE; t++) \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#329: FILE: app/test/test_memcpy_perf.c:209:
+ for (t = 0; t < TEST_BATCH_SIZE; t++) \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#330: FILE: app/test/test_memcpy_perf.c:210:
+ rte_memcpy_ex(dst+dst_addrs[t], src+src_addrs[t], size, \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#330: FILE: app/test/test_memcpy_perf.c:210:
+ rte_memcpy_ex(dst+dst_addrs[t], src+src_addrs[t], size, \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#331: FILE: app/test/test_memcpy_perf.c:211:
+ flags | RTE_MEMOPS_F_DST_NT); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#331: FILE: app/test/test_memcpy_perf.c:211:
+ flags | RTE_MEMOPS_F_DST_NT); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#332: FILE: app/test/test_memcpy_perf.c:212:
+ total_time_ntd += rte_rdtsc() - start_time; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#332: FILE: app/test/test_memcpy_perf.c:212:
+ total_time_ntd += rte_rdtsc() - start_time; \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#333: FILE: app/test/test_memcpy_perf.c:213:
+ } \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#333: FILE: app/test/test_memcpy_perf.c:213:
+ } \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#334: FILE: app/test/test_memcpy_perf.c:214:
+ for (iter = 0; iter < (TEST_ITERATIONS / TEST_BATCH_SIZE); iter++) { \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#334: FILE: app/test/test_memcpy_perf.c:214:
+ for (iter = 0; iter < (TEST_ITERATIONS / TEST_BATCH_SIZE); iter++) { \$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#334: FILE: app/test/test_memcpy_perf.c:214:
+ for (iter = 0; iter < (TEST_ITERATIONS / TEST_BATCH_SIZE); iter++) { \
+ fill_addr_arrays(dst_addrs, is_dst_cached, dst_uoffset, \
ERROR:CODE_INDENT: code indent should use tabs where possible
#335: FILE: app/test/test_memcpy_perf.c:215:
+ fill_addr_arrays(dst_addrs, is_dst_cached, dst_uoffset, \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#335: FILE: app/test/test_memcpy_perf.c:215:
+ fill_addr_arrays(dst_addrs, is_dst_cached, dst_uoffset, \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#336: FILE: app/test/test_memcpy_perf.c:216:
+ src_addrs, is_src_cached, src_uoffset); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#336: FILE: app/test/test_memcpy_perf.c:216:
+ src_addrs, is_src_cached, src_uoffset); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#337: FILE: app/test/test_memcpy_perf.c:217:
+ start_time = rte_rdtsc(); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#337: FILE: app/test/test_memcpy_perf.c:217:
+ start_time = rte_rdtsc(); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#338: FILE: app/test/test_memcpy_perf.c:218:
+ for (t = 0; t < TEST_BATCH_SIZE; t++) \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#338: FILE: app/test/test_memcpy_perf.c:218:
+ for (t = 0; t < TEST_BATCH_SIZE; t++) \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#339: FILE: app/test/test_memcpy_perf.c:219:
+ rte_memcpy_ex(dst+dst_addrs[t], src+src_addrs[t], size, \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#339: FILE: app/test/test_memcpy_perf.c:219:
+ rte_memcpy_ex(dst+dst_addrs[t], src+src_addrs[t], size, \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#340: FILE: app/test/test_memcpy_perf.c:220:
+ flags | RTE_MEMOPS_F_SRC_NT); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#340: FILE: app/test/test_memcpy_perf.c:220:
+ flags | RTE_MEMOPS_F_SRC_NT); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#341: FILE: app/test/test_memcpy_perf.c:221:
+ total_time_nts += rte_rdtsc() - start_time; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#341: FILE: app/test/test_memcpy_perf.c:221:
+ total_time_nts += rte_rdtsc() - start_time; \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#342: FILE: app/test/test_memcpy_perf.c:222:
+ } \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#342: FILE: app/test/test_memcpy_perf.c:222:
+ } \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#343: FILE: app/test/test_memcpy_perf.c:223:
+ for (iter = 0; iter < (TEST_ITERATIONS / TEST_BATCH_SIZE); iter++) { \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#343: FILE: app/test/test_memcpy_perf.c:223:
+ for (iter = 0; iter < (TEST_ITERATIONS / TEST_BATCH_SIZE); iter++) { \$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#343: FILE: app/test/test_memcpy_perf.c:223:
+ for (iter = 0; iter < (TEST_ITERATIONS / TEST_BATCH_SIZE); iter++) { \
+ fill_addr_arrays(dst_addrs, is_dst_cached, dst_uoffset, \
ERROR:CODE_INDENT: code indent should use tabs where possible
#344: FILE: app/test/test_memcpy_perf.c:224:
+ fill_addr_arrays(dst_addrs, is_dst_cached, dst_uoffset, \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#344: FILE: app/test/test_memcpy_perf.c:224:
+ fill_addr_arrays(dst_addrs, is_dst_cached, dst_uoffset, \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#345: FILE: app/test/test_memcpy_perf.c:225:
+ src_addrs, is_src_cached, src_uoffset); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#345: FILE: app/test/test_memcpy_perf.c:225:
+ src_addrs, is_src_cached, src_uoffset); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#346: FILE: app/test/test_memcpy_perf.c:226:
+ start_time = rte_rdtsc(); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#346: FILE: app/test/test_memcpy_perf.c:226:
+ start_time = rte_rdtsc(); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#347: FILE: app/test/test_memcpy_perf.c:227:
+ for (t = 0; t < TEST_BATCH_SIZE; t++) \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#347: FILE: app/test/test_memcpy_perf.c:227:
+ for (t = 0; t < TEST_BATCH_SIZE; t++) \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#348: FILE: app/test/test_memcpy_perf.c:228:
+ rte_memcpy_ex(dst+dst_addrs[t], src+src_addrs[t], size, \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#348: FILE: app/test/test_memcpy_perf.c:228:
+ rte_memcpy_ex(dst+dst_addrs[t], src+src_addrs[t], size, \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#349: FILE: app/test/test_memcpy_perf.c:229:
+ flags | RTE_MEMOPS_F_DST_NT | RTE_MEMOPS_F_SRC_NT); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#349: FILE: app/test/test_memcpy_perf.c:229:
+ flags | RTE_MEMOPS_F_DST_NT | RTE_MEMOPS_F_SRC_NT); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#350: FILE: app/test/test_memcpy_perf.c:230:
+ total_time_nt += rte_rdtsc() - start_time; \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#350: FILE: app/test/test_memcpy_perf.c:230:
+ total_time_nt += rte_rdtsc() - start_time; \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#351: FILE: app/test/test_memcpy_perf.c:231:
+ } \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#351: FILE: app/test/test_memcpy_perf.c:231:
+ } \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#352: FILE: app/test/test_memcpy_perf.c:232:
+ } \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#353: FILE: app/test/test_memcpy_perf.c:233:
+ printf(" %4.0f-", (double)total_time_rte / TEST_ITERATIONS); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#354: FILE: app/test/test_memcpy_perf.c:234:
+ printf("%4.0f", (double)total_time_std / TEST_ITERATIONS); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#355: FILE: app/test/test_memcpy_perf.c:235:
+ printf("(%+4.0f%%)", ((double)total_time_rte - total_time_std)*100/total_time_std); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#356: FILE: app/test/test_memcpy_perf.c:236:
+ if (!(is_dst_cached && is_src_cached)) { \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#357: FILE: app/test/test_memcpy_perf.c:237:
+ printf(" %4.0f", (double)total_time_ntd / TEST_ITERATIONS); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#357: FILE: app/test/test_memcpy_perf.c:237:
+ printf(" %4.0f", (double)total_time_ntd / TEST_ITERATIONS); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#358: FILE: app/test/test_memcpy_perf.c:238:
+ printf(" %4.0f", (double)total_time_nts / TEST_ITERATIONS); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#358: FILE: app/test/test_memcpy_perf.c:238:
+ printf(" %4.0f", (double)total_time_nts / TEST_ITERATIONS); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#359: FILE: app/test/test_memcpy_perf.c:239:
+ printf(" %4.0f", (double)total_time_nt / TEST_ITERATIONS); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#359: FILE: app/test/test_memcpy_perf.c:239:
+ printf(" %4.0f", (double)total_time_nt / TEST_ITERATIONS); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#360: FILE: app/test/test_memcpy_perf.c:240:
+ if (total_time_nt / total_time_std > 9) \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#360: FILE: app/test/test_memcpy_perf.c:240:
+ if (total_time_nt / total_time_std > 9) \$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#360: FILE: app/test/test_memcpy_perf.c:240:
+ if (total_time_nt / total_time_std > 9) \
+ printf("(*%4.1f)", (double)total_time_nt/total_time_std); \
ERROR:CODE_INDENT: code indent should use tabs where possible
#361: FILE: app/test/test_memcpy_perf.c:241:
+ printf("(*%4.1f)", (double)total_time_nt/total_time_std); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#361: FILE: app/test/test_memcpy_perf.c:241:
+ printf("(*%4.1f)", (double)total_time_nt/total_time_std); \$
ERROR:CODE_INDENT: code indent should use tabs where possible
#362: FILE: app/test/test_memcpy_perf.c:242:
+ else \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#362: FILE: app/test/test_memcpy_perf.c:242:
+ else \$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 12)
#362: FILE: app/test/test_memcpy_perf.c:242:
+ else \
+ printf("(%+4.0f%%)", ((double)total_time_nt - total_time_std)*100/total_time_std); \
ERROR:CODE_INDENT: code indent should use tabs where possible
#363: FILE: app/test/test_memcpy_perf.c:243:
+ printf("(%+4.0f%%)", ((double)total_time_nt - total_time_std)*100/total_time_std); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#363: FILE: app/test/test_memcpy_perf.c:243:
+ printf("(%+4.0f%%)", ((double)total_time_nt - total_time_std)*100/total_time_std); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#364: FILE: app/test/test_memcpy_perf.c:244:
+ } \$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 4)
#371: FILE: app/test/test_memcpy_perf.c:275:
do { \
+ TEST_CONSTANT(4U); TEST_CONSTANT(6U); TEST_CONSTANT(8U); \
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#373: FILE: app/test/test_memcpy_perf.c:276:
+ TEST_CONSTANT(4U); TEST_CONSTANT(6U); TEST_CONSTANT(8U); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#374: FILE: app/test/test_memcpy_perf.c:277:
+ TEST_CONSTANT(16U); TEST_CONSTANT(64U); TEST_CONSTANT(128U); \$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#377: FILE: app/test/test_memcpy_perf.c:280:
+ TEST_CONSTANT(2048U); \$
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#544: FILE: lib/eal/include/generic/rte_memcpy.h:211:
+void rte_memcpy_ex(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#544: FILE: lib/eal/include/generic/rte_memcpy.h:211:
+void rte_memcpy_ex(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#556: FILE: lib/eal/include/generic/rte_memcpy.h:223:
+void rte_memcpy_ex(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#556: FILE: lib/eal/include/generic/rte_memcpy.h:223:
+void rte_memcpy_ex(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#640: FILE: lib/eal/x86/include/rte_memcpy.h:925:
+void rte_memcpy_nts(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#640: FILE: lib/eal/x86/include/rte_memcpy.h:925:
+void rte_memcpy_nts(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#653: FILE: lib/eal/x86/include/rte_memcpy.h:938:
+ if (unlikely(len == 0)) return;
WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#670: FILE: lib/eal/x86/include/rte_memcpy.h:955:
+ /** How many bytes is source away from 16 byte alignment (ceiling rounding). */
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#784: FILE: lib/eal/x86/include/rte_memcpy.h:1069:
+void rte_memcpy_ntd(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#784: FILE: lib/eal/x86/include/rte_memcpy.h:1069:
+void rte_memcpy_ntd(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#795: FILE: lib/eal/x86/include/rte_memcpy.h:1080:
+ if (unlikely(len == 0)) return;
WARNING:LONG_LINE_COMMENT: line length of 108 exceeds 100 columns
#811: FILE: lib/eal/x86/include/rte_memcpy.h:1096:
+ /** How many bytes is destination offset from 16 byte alignment (floor rounding). */
WARNING:LONG_LINE_COMMENT: line length of 116 exceeds 100 columns
#816: FILE: lib/eal/x86/include/rte_memcpy.h:1101:
+ /** How many bytes is destination away from 16 byte alignment (ceiling rounding). */
WARNING:TYPO_SPELLING: 'repectively' may be misspelled - perhaps 'respectively'?
#948: FILE: lib/eal/x86/include/rte_memcpy.h:1233:
+ * and length is known to be repectively 4 and 2 byte aligned.
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#989: FILE: lib/eal/x86/include/rte_memcpy.h:1274:
+void rte_memcpy_nt_15_or_less_s16a(void * __rte_restrict dst,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#990: FILE: lib/eal/x86/include/rte_memcpy.h:1275:
+ const void * __rte_restrict src, size_t len, const uint64_t flags)
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1007: FILE: lib/eal/x86/include/rte_memcpy.h:1292:
+ if ((len & 15) == 0) return;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1075: FILE: lib/eal/x86/include/rte_memcpy.h:1360:
+void rte_memcpy_nt_d16s16a(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1075: FILE: lib/eal/x86/include/rte_memcpy.h:1360:
+void rte_memcpy_nt_d16s16a(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1093: FILE: lib/eal/x86/include/rte_memcpy.h:1378:
+ if (unlikely(len == 0)) return;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1166: FILE: lib/eal/x86/include/rte_memcpy.h:1451:
+void rte_memcpy_nt_d8s16a(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1166: FILE: lib/eal/x86/include/rte_memcpy.h:1451:
+void rte_memcpy_nt_d8s16a(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1185: FILE: lib/eal/x86/include/rte_memcpy.h:1470:
+ if (unlikely(len == 0)) return;
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1272: FILE: lib/eal/x86/include/rte_memcpy.h:1557:
+void rte_memcpy_nt_d4s16a(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1272: FILE: lib/eal/x86/include/rte_memcpy.h:1557:
+void rte_memcpy_nt_d4s16a(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1291: FILE: lib/eal/x86/include/rte_memcpy.h:1576:
+ if (unlikely(len == 0)) return;
ERROR:SPACING: space prohibited after that open square bracket '['
#1303: FILE: lib/eal/x86/include/rte_memcpy.h:1588:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 0 * 4), buffer[ 0]);
ERROR:SPACING: space prohibited after that open square bracket '['
#1304: FILE: lib/eal/x86/include/rte_memcpy.h:1589:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 1 * 4), buffer[ 1]);
ERROR:SPACING: space prohibited after that open square bracket '['
#1305: FILE: lib/eal/x86/include/rte_memcpy.h:1590:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 2 * 4), buffer[ 2]);
ERROR:SPACING: space prohibited after that open square bracket '['
#1306: FILE: lib/eal/x86/include/rte_memcpy.h:1591:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 3 * 4), buffer[ 3]);
ERROR:SPACING: space prohibited after that open square bracket '['
#1307: FILE: lib/eal/x86/include/rte_memcpy.h:1592:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 4 * 4), buffer[ 4]);
ERROR:SPACING: space prohibited after that open square bracket '['
#1308: FILE: lib/eal/x86/include/rte_memcpy.h:1593:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 5 * 4), buffer[ 5]);
ERROR:SPACING: space prohibited after that open square bracket '['
#1309: FILE: lib/eal/x86/include/rte_memcpy.h:1594:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 6 * 4), buffer[ 6]);
ERROR:SPACING: space prohibited after that open square bracket '['
#1310: FILE: lib/eal/x86/include/rte_memcpy.h:1595:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 7 * 4), buffer[ 7]);
ERROR:SPACING: space prohibited after that open square bracket '['
#1311: FILE: lib/eal/x86/include/rte_memcpy.h:1596:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 8 * 4), buffer[ 8]);
ERROR:SPACING: space prohibited after that open square bracket '['
#1312: FILE: lib/eal/x86/include/rte_memcpy.h:1597:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 9 * 4), buffer[ 9]);
ERROR:SPACING: space prohibited after that open square bracket '['
#1349: FILE: lib/eal/x86/include/rte_memcpy.h:1634:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 0 * 4), buffer[ 8]);
ERROR:SPACING: space prohibited after that open square bracket '['
#1350: FILE: lib/eal/x86/include/rte_memcpy.h:1635:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 1 * 4), buffer[ 9]);
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1392: FILE: lib/eal/x86/include/rte_memcpy.h:1677:
+void rte_memcpy_nt_d4s4a(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1392: FILE: lib/eal/x86/include/rte_memcpy.h:1677:
+void rte_memcpy_nt_d4s4a(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1412: FILE: lib/eal/x86/include/rte_memcpy.h:1697:
+ if (unlikely(len == 0)) return;
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#1440: FILE: lib/eal/x86/include/rte_memcpy.h:1725:
+ switch (len) {
+ case 1 * 4:
[...]
+ case 2 * 4:
[...]
+ case 3 * 4:
WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#1443: FILE: lib/eal/x86/include/rte_memcpy.h:1728:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 0 * 4), buffer[offset / 4]);
WARNING:LONG_LINE: line length of 109 exceeds 100 columns
#1447: FILE: lib/eal/x86/include/rte_memcpy.h:1732:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 0 * 4), buffer[offset / 4]);
WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#1448: FILE: lib/eal/x86/include/rte_memcpy.h:1733:
+ _mm_stream_si32(RTE_PTR_ADD(dst, 1 * 4), buffer[offset / 4 + 1]);
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#1464: FILE: lib/eal/x86/include/rte_memcpy.h:1749:
+ switch (first) {
+ case 1 * 4:
[...]
+ case 2 * 4:
[...]
+ case 3 * 4:
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1549: FILE: lib/eal/x86/include/rte_memcpy.h:1834:
+void rte_memcpy_nt_buf(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1549: FILE: lib/eal/x86/include/rte_memcpy.h:1834:
+void rte_memcpy_nt_buf(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * const bar" should be "foo * const bar"
#1562: FILE: lib/eal/x86/include/rte_memcpy.h:1847:
+ char * const buf0 = &buffer[RTE_CACHE_LINE_SIZE];
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1563: FILE: lib/eal/x86/include/rte_memcpy.h:1848:
+ void * buf;
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#1580: FILE: lib/eal/x86/include/rte_memcpy.h:1865:
+ if (unlikely(len == 0)) return;
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1595: FILE: lib/eal/x86/include/rte_memcpy.h:1880:
+ * unless source is known to be 16 byte aligned. */
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1677: FILE: lib/eal/x86/include/rte_memcpy.h:1962:
+void rte_memcpy_nt_generic(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1677: FILE: lib/eal/x86/include/rte_memcpy.h:1962:
+void rte_memcpy_nt_generic(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1699: FILE: lib/eal/x86/include/rte_memcpy.h:1984:
+void rte_memcpy_ex(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#1699: FILE: lib/eal/x86/include/rte_memcpy.h:1984:
+void rte_memcpy_ex(void * __rte_restrict dst, const void * __rte_restrict src, size_t len,
total: 91 errors, 70 warnings, 1745 lines checked
Warning in lib/eal/include/generic/rte_memcpy.h:
Using compiler attribute directly
next parent reply other threads:[~2022-10-06 20:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221006203426.78743-1-mb@smartsharesystems.com>
2022-10-06 20:35 ` checkpatch [this message]
2022-10-06 21:39 ` |FAILURE| " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221006203545.ABC64120EFA@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).