|WARNING| pw117825 [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

|WARNING| pw117825 [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/117825

_coding style issues_


WARNING:BRACES: braces {} are not necessary for single statement blocks
#114: FILE: lib/gro/gro_tcp4.c:224:
+	if (unlikely(pkt->pkt_len > (uint32_t)(ip_len + pkt->l2_len))) {
+		pkt->pkt_len = ip_len + pkt->l2_len;
+	}

total: 0 errors, 1 warnings, 20 lines checked

|WARNING| pw117825 [PATCH] gro : fix pkt length when extra bytes are padded to ethernet frame

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 1062 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/117825

_apply patch failure_

Submitter: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
Date: Monday, October 10 2022 17:51:09 
Applied on: CommitID:629dad3ef325f9b4519d94c29ec49b77b386d850
Apply patch set 117825 failed:

Checking patch lib/gro/gro_tcp4.c...
error: while searching for:
	struct rte_tcp_hdr *tcp_hdr;
	uint32_t sent_seq;
	int32_t tcp_dl;
	uint16_t ip_id, hdr_len, frag_off;
	uint8_t is_atomic;

	struct tcp4_flow_key key;

error: patch failed: lib/gro/gro_tcp4.c:198
Applying patch lib/gro/gro_tcp4.c with 1 reject...
Rejected hunk #1.
Hunk #2 applied cleanly.
diff a/lib/gro/gro_tcp4.c b/lib/gro/gro_tcp4.c	(rejected hunks)
@@ -198,7 +198,7 @@ gro_tcp4_reassemble(struct rte_mbuf *pkt,
 	struct rte_tcp_hdr *tcp_hdr;
 	uint32_t sent_seq;
 	int32_t tcp_dl;
-	uint16_t ip_id, hdr_len, frag_off;
+	uint16_t ip_id, hdr_len, frag_off, ip_len;
 	uint8_t is_atomic;
 
 	struct tcp4_flow_key key;

https://lab.dpdk.org/results/dashboard/patchsets/23868/

UNH-IOL DPDK Community Lab