|WARNING| pw117843 [PATCH] [v1, 15/35] net/ionic: free all buffers during Rx queue stop

|WARNING| pw117843 [PATCH] [v1, 15/35] net/ionic: free all buffers during Rx queue stop

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 4222 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/117843

_apply patch failure_

Submitter: Andrew Boyer <Andrew.Boyer@amd.com>
Date: Tuesday, October 11 2022 00:50:12 
Applied on: CommitID:f13604fad12a81383da7b04821a4befb3d01e2ed
Apply patch set 117843 failed:

Checking patch drivers/net/ionic/ionic_dev.c...
Hunk #1 succeeded at 376 (offset 59 lines).
Hunk #2 succeeded at 447 (offset 59 lines).
Checking patch drivers/net/ionic/ionic_dev.h...
Hunk #1 succeeded at 215 (offset -10 lines).
Hunk #2 succeeded at 223 (offset -10 lines).
Checking patch drivers/net/ionic/ionic_lif.c...
error: while searching for:
	for (i = 0; i < lif->nrxqcqs; i++) {
		struct ionic_rx_stats *rx_stats = &lif->rxqcqs[i]->stats;
		stats->ierrors +=
			rx_stats->no_cb_arg +
			rx_stats->bad_cq_status +
			rx_stats->no_room +
			rx_stats->bad_len;

error: patch failed: drivers/net/ionic/ionic_lif.c:133
Hunk #3 succeeded at 138 (offset 3 lines).
Hunk #4 succeeded at 1144 (offset 18 lines).
Hunk #5 succeeded at 1484 (offset 12 lines).
Hunk #6 succeeded at 1535 (offset 12 lines).
Checking patch drivers/net/ionic/ionic_lif.h...
Hunk #2 succeeded at 204 (offset -2 lines).
Checking patch drivers/net/ionic/ionic_rxtx.c...
Hunk #5 succeeded at 669 (offset -3 lines).
error: while searching for:

	rxm = info[0];

	if (!rx_svc) {
		stats->no_cb_arg++;
		/* Flush */
		rte_pktmbuf_free(rxm);
		/*
		 * Note: rte_mempool_put is faster with no segs
		 * rte_mempool_put(rxq->mb_pool, rxm);
		 */
		return;
	}

	if (cq_desc->status) {
		stats->bad_cq_status++;
		ionic_rx_recycle(q, q_desc_index, rxm);

error: patch failed: drivers/net/ionic/ionic_rxtx.c:787
error: while searching for:
	IONIC_PRINT(DEBUG, "Starting RX queue %u, %u descs, size %u",
		rx_queue_id, rxq->qcq.q.num_descs, rxq->frame_size);

	if (!(rxq->flags & IONIC_QCQ_F_INITED)) {
		err = ionic_lif_rxq_init(rxq);
		if (err)
			return err;
	} else {
		ionic_qcq_enable(&rxq->qcq);
	}

	/* Allocate buffers for descriptor rings */
	if (ionic_rx_fill(rxq) != 0) {

error: patch failed: drivers/net/ionic/ionic_rxtx.c:1028
Hunk #8 succeeded at 1102 (offset 16 lines).
Applied patch drivers/net/ionic/ionic_dev.c cleanly.
Applied patch drivers/net/ionic/ionic_dev.h cleanly.
Applying patch drivers/net/ionic/ionic_lif.c with 1 reject...
Hunk #1 applied cleanly.
Rejected hunk #2.
Hunk #3 applied cleanly.
Hunk #4 applied cleanly.
Hunk #5 applied cleanly.
Hunk #6 applied cleanly.
Applied patch drivers/net/ionic/ionic_lif.h cleanly.
Applying patch drivers/net/ionic/ionic_rxtx.c with 2 rejects...
Hunk #1 applied cleanly.
Hunk #2 applied cleanly.
Hunk #3 applied cleanly.
Hunk #4 applied cleanly.
Hunk #5 applied cleanly.
Rejected hunk #6.
Rejected hunk #7.
Hunk #8 applied cleanly.
diff a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c	(rejected hunks)
@@ -133,7 +115,6 @@ ionic_lif_get_abs_stats(const struct ionic_lif *lif, struct rte_eth_stats *stats
 	for (i = 0; i < lif->nrxqcqs; i++) {
 		struct ionic_rx_stats *rx_stats = &lif->rxqcqs[i]->stats;
 		stats->ierrors +=
-			rx_stats->no_cb_arg +
 			rx_stats->bad_cq_status +
 			rx_stats->no_room +
 			rx_stats->bad_len;
diff a/drivers/net/ionic/ionic_rxtx.c b/drivers/net/ionic/ionic_rxtx.c	(rejected hunks)
@@ -787,17 +785,6 @@ ionic_rx_clean(struct ionic_rx_qcq *rxq,
 
 	rxm = info[0];
 
-	if (!rx_svc) {
-		stats->no_cb_arg++;
-		/* Flush */
-		rte_pktmbuf_free(rxm);
-		/*
-		 * Note: rte_mempool_put is faster with no segs
-		 * rte_mempool_put(rxq->mb_pool, rxm);
-		 */
-		return;
-	}
-
 	if (cq_desc->status) {
 		stats->bad_cq_status++;
 		ionic_rx_recycle(q, q_desc_index, rxm);
@@ -1028,13 +1015,9 @@ ionic_dev_rx_queue_start(struct rte_eth_dev *eth_dev, uint16_t rx_queue_id)
 	IONIC_PRINT(DEBUG, "Starting RX queue %u, %u descs, size %u",
 		rx_queue_id, rxq->qcq.q.num_descs, rxq->frame_size);
 
-	if (!(rxq->flags & IONIC_QCQ_F_INITED)) {
-		err = ionic_lif_rxq_init(rxq);
-		if (err)
-			return err;
-	} else {
-		ionic_qcq_enable(&rxq->qcq);
-	}
+	err = ionic_lif_rxq_init(rxq);
+	if (err)
+		return err;
 
 	/* Allocate buffers for descriptor rings */
 	if (ionic_rx_fill(rxq) != 0) {

https://lab.dpdk.org/results/dashboard/patchsets/23884/

UNH-IOL DPDK Community Lab