From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Alex Vesker <valex@nvidia.com>
Subject: |WARNING| pw118219 [v3 16/18] net/mlx5/hws: Add HWS action object
Date: Fri, 14 Oct 2022 13:52:43 +0200 (CEST) [thread overview]
Message-ID: <20221014115243.50A87120778@dpdk.org> (raw)
In-Reply-To: <20221014114833.13389-17-valex@nvidia.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/118219
_coding style issues_
ERROR:SPACING: space required before the open parenthesis '('
#2064: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:1921:
+ switch(rule_action->action->type) {
WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2216: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2073:
+ setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_MODIFY);
WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#2225: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2082:
+ setter = mlx5dr_action_setter_find_first(last_setter, ASF_DOUBLE | ASF_REMOVE);
WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#2233: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2090:
+ setter = mlx5dr_action_setter_find_first(last_setter, ASF_DOUBLE | ASF_REMOVE);
WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2249: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2106:
+ setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_MODIFY);
WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#2265: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2122:
+ setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_DOUBLE);
ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#2339: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2196:
+ while (action_type[num_actions++] != MLX5DR_ACTION_TYP_LAST);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cur_num_of_actions != num_of_actions'
#2701: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:72:
+ if ((cur_num_of_actions != num_of_actions) || (cur_type != type))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cur_type != type'
#2701: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:72:
+ if ((cur_num_of_actions != num_of_actions) || (cur_type != type))
WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#2773: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:144:
+ if (cached_pattern->mh_data.pattern_obj->id == action->modify_header.pattern_obj->id)
CHECK:SPACING: No space is necessary after a cast
#2935: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:306:
+ mlx5dr_action_prepare_decap_l3_data(arg_data, (uint8_t *) wqe_arg,
ERROR:C99_COMMENTS: do not use C99 // comments
#2996: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:367:
+ memset(wqe_ctrl, 0, wqe_len); // TODO OPT: GTA ctrl might be ignored in case of arg
total: 3 errors, 6 warnings, 3 checks, 3068 lines checked
Warning in drivers/net/mlx5/hws/mlx5dr_action.c:
Using rte_atomicNN_xxx
parent reply other threads:[~2022-10-14 11:52 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20221014114833.13389-17-valex@nvidia.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221014115243.50A87120778@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=valex@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).