From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93551A00C2 for ; Fri, 14 Oct 2022 13:52:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8EAD642D92; Fri, 14 Oct 2022 13:52:44 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 570A742D90 for ; Fri, 14 Oct 2022 13:52:43 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 50A87120778; Fri, 14 Oct 2022 13:52:43 +0200 (CEST) Subject: |WARNING| pw118219 [v3 16/18] net/mlx5/hws: Add HWS action object In-Reply-To: <20221014114833.13389-17-valex@nvidia.com> References: <20221014114833.13389-17-valex@nvidia.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Alex Vesker Message-Id: <20221014115243.50A87120778@dpdk.org> Date: Fri, 14 Oct 2022 13:52:43 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/118219 _coding style issues_ ERROR:SPACING: space required before the open parenthesis '(' #2064: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:1921: + switch(rule_action->action->type) { WARNING:LONG_LINE: line length of 104 exceeds 100 columns #2216: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2073: + setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_MODIFY); WARNING:LONG_LINE: line length of 103 exceeds 100 columns #2225: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2082: + setter = mlx5dr_action_setter_find_first(last_setter, ASF_DOUBLE | ASF_REMOVE); WARNING:LONG_LINE: line length of 103 exceeds 100 columns #2233: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2090: + setter = mlx5dr_action_setter_find_first(last_setter, ASF_DOUBLE | ASF_REMOVE); WARNING:LONG_LINE: line length of 104 exceeds 100 columns #2249: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2106: + setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_MODIFY); WARNING:LONG_LINE: line length of 104 exceeds 100 columns #2265: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2122: + setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_DOUBLE); ERROR:TRAILING_STATEMENTS: trailing statements should be on next line #2339: FILE: drivers/net/mlx5/hws/mlx5dr_action.c:2196: + while (action_type[num_actions++] != MLX5DR_ACTION_TYP_LAST); CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cur_num_of_actions != num_of_actions' #2701: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:72: + if ((cur_num_of_actions != num_of_actions) || (cur_type != type)) CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'cur_type != type' #2701: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:72: + if ((cur_num_of_actions != num_of_actions) || (cur_type != type)) WARNING:LONG_LINE: line length of 101 exceeds 100 columns #2773: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:144: + if (cached_pattern->mh_data.pattern_obj->id == action->modify_header.pattern_obj->id) CHECK:SPACING: No space is necessary after a cast #2935: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:306: + mlx5dr_action_prepare_decap_l3_data(arg_data, (uint8_t *) wqe_arg, ERROR:C99_COMMENTS: do not use C99 // comments #2996: FILE: drivers/net/mlx5/hws/mlx5dr_pat_arg.c:367: + memset(wqe_ctrl, 0, wqe_len); // TODO OPT: GTA ctrl might be ignored in case of arg total: 3 errors, 6 warnings, 3 checks, 3068 lines checked Warning in drivers/net/mlx5/hws/mlx5dr_action.c: Using rte_atomicNN_xxx