From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23CB3A0560 for ; Tue, 18 Oct 2022 13:16:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F57640395; Tue, 18 Oct 2022 13:16:15 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id CE80D4021D for ; Tue, 18 Oct 2022 13:16:13 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id C49DD120778; Tue, 18 Oct 2022 13:16:13 +0200 (CEST) Subject: |WARNING| pw118361 [PATCH v3 01/15] common/idpf: introduce common library In-Reply-To: <20221018111245.890651-2-junfeng.guo@intel.com> References: <20221018111245.890651-2-junfeng.guo@intel.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Junfeng Guo Message-Id: <20221018111613.C49DD120778@dpdk.org> Date: Tue, 18 Oct 2022 13:16:13 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/118361 _coding style issues_ WARNING:TYPO_SPELLING: 'definations' may be misspelled - perhaps 'definitions'? #71: Also add OS specific implementation about some MACRO definations and WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'idpf_set_mac_type', this function's name, in a string #174: FILE: drivers/common/idpf/idpf_common.c:21: + DEBUGFUNC("idpf_set_mac_type "); WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'idpf_set_mac_type', this function's name, in a string #192: FILE: drivers/common/idpf/idpf_common.c:39: + DEBUGOUT2("idpf_set_mac_type found mac: %d, returns: %d ", ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #1245: FILE: drivers/common/idpf/idpf_controlq.h:25: +#define IDPF_CTLQ_DESC_UNUSED(R) \ + (u16)((((R)->next_to_clean > (R)->next_to_use) ? 0 : (R)->ring_size) + \ + (R)->next_to_clean - (R)->next_to_use - 1) WARNING:TYPO_SPELLING: 'belwo' may be misspelled - perhaps 'below'? #2093: FILE: drivers/common/idpf/idpf_lan_txrx.h:54: + /* TODO: Wrap belwo comment under internal flag WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2490: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:17: +#define VF_ATQBAL ^I^I(VF_BASE + 0x1C00)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2491: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:18: +#define VF_ATQBAH ^I^I(VF_BASE + 0x1800)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2492: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:19: +#define VF_ATQLEN ^I^I(VF_BASE + 0x0800)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2493: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:20: +#define VF_ATQLEN_ATQLEN_S ^I^I0$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2494: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:21: +#define VF_ATQLEN_ATQLEN_M ^I^IMAKEMASK(0x3FF, VF_ATQLEN_ATQLEN_S)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2495: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:22: +#define VF_ATQLEN_ATQVFE_S ^I^I28$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2496: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:23: +#define VF_ATQLEN_ATQVFE_M ^I^IBIT(VF_ATQLEN_ATQVFE_S)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2497: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:24: +#define VF_ATQLEN_ATQOVFL_S ^I^I29$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2498: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:25: +#define VF_ATQLEN_ATQOVFL_M ^I^IBIT(VF_ATQLEN_ATQOVFL_S)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2499: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:26: +#define VF_ATQLEN_ATQCRIT_S ^I^I30$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2500: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:27: +#define VF_ATQLEN_ATQCRIT_M ^I^IBIT(VF_ATQLEN_ATQCRIT_S)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2501: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:28: +#define VF_ATQLEN_ATQENABLE_S ^I^I31$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2502: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:29: +#define VF_ATQLEN_ATQENABLE_M ^I^IBIT(VF_ATQLEN_ATQENABLE_S)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2503: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:30: +#define VF_ATQH ^I^I(VF_BASE + 0x0400)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2504: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:31: +#define VF_ATQH_ATQH_S ^I^I0$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2505: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:32: +#define VF_ATQH_ATQH_M ^I^I^IMAKEMASK(0x3FF, VF_ATQH_ATQH_S)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2506: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:33: +#define VF_ATQT ^I^I(VF_BASE + 0x2400)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2508: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:35: +#define VF_ARQBAL ^I^I(VF_BASE + 0x0C00)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2509: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:36: +#define VF_ARQBAH ^I^I(VF_BASE)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2510: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:37: +#define VF_ARQLEN ^I^I(VF_BASE + 0x2000)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2511: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:38: +#define VF_ARQLEN_ARQLEN_S ^I^I0$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2512: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:39: +#define VF_ARQLEN_ARQLEN_M ^I^IMAKEMASK(0x3FF, VF_ARQLEN_ARQLEN_S)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2513: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:40: +#define VF_ARQLEN_ARQVFE_S ^I^I28$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2514: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:41: +#define VF_ARQLEN_ARQVFE_M ^I^IBIT(VF_ARQLEN_ARQVFE_S)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2515: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:42: +#define VF_ARQLEN_ARQOVFL_S ^I^I29$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2516: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:43: +#define VF_ARQLEN_ARQOVFL_M ^I^IBIT(VF_ARQLEN_ARQOVFL_S)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2517: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:44: +#define VF_ARQLEN_ARQCRIT_S ^I^I30$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2518: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:45: +#define VF_ARQLEN_ARQCRIT_M ^I^IBIT(VF_ARQLEN_ARQCRIT_S)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2519: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:46: +#define VF_ARQLEN_ARQENABLE_S ^I^I31$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2521: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:48: +#define VF_ARQH ^I^I(VF_BASE + 0x1400)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2522: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:49: +#define VF_ARQH_ARQH_S ^I^I0$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2523: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:50: +#define VF_ARQH_ARQH_M ^I^IMAKEMASK(0x1FFF, VF_ARQH_ARQH_S)$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #2524: FILE: drivers/common/idpf/idpf_lan_vf_regs.h:51: +#define VF_ARQT ^I^I(VF_BASE + 0x1000)$ WARNING:ARRAY_SIZE: Prefer ARRAY_SIZE(arr) #2691: FILE: drivers/common/idpf/idpf_osdep.h:98: +#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof(arr[0])) WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #3026: FILE: drivers/common/idpf/idpf_type.h:11: +#define UNREFERENCED_1PARAMETER(_p) (_p); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #3027: FILE: drivers/common/idpf/idpf_type.h:12: +#define UNREFERENCED_2PARAMETER(_p, _q) (_p); (_q); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #3027: FILE: drivers/common/idpf/idpf_type.h:12: +#define UNREFERENCED_2PARAMETER(_p, _q) (_p); (_q); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #3028: FILE: drivers/common/idpf/idpf_type.h:13: +#define UNREFERENCED_3PARAMETER(_p, _q, _r) (_p); (_q); (_r); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #3028: FILE: drivers/common/idpf/idpf_type.h:13: +#define UNREFERENCED_3PARAMETER(_p, _q, _r) (_p); (_q); (_r); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #3029: FILE: drivers/common/idpf/idpf_type.h:14: +#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (_p); (_q); (_r); (_s); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #3029: FILE: drivers/common/idpf/idpf_type.h:14: +#define UNREFERENCED_4PARAMETER(_p, _q, _r, _s) (_p); (_q); (_r); (_s); ERROR:MULTISTATEMENT_MACRO_USE_DO_WHILE: Macros with multiple statements should be enclosed in a do - while loop #3030: FILE: drivers/common/idpf/idpf_type.h:15: +#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (_p); (_q); (_r); (_s); (_t); WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon #3030: FILE: drivers/common/idpf/idpf_type.h:15: +#define UNREFERENCED_5PARAMETER(_p, _q, _r, _s, _t) (_p); (_q); (_r); (_s); (_t); WARNING:LONG_LINE_COMMENT: line length of 118 exceeds 100 columns #3171: FILE: drivers/common/idpf/siov_regs.h:23: +#define VDEV_QRX_BUFQ_TAIL_START 0x900000 /* Begin at offset of 9MB for Rx buffer queue tail register pages */ WARNING:LONG_LINE_COMMENT: line length of 110 exceeds 100 columns #3172: FILE: drivers/common/idpf/siov_regs.h:24: +#define VDEV_QRX_BUFQ_TAIL(_i) (VDEV_QRX_BUFQ_TAIL_START + ((_i) * 0x1000)) /* 2k Rx buffer queues */ WARNING:LONG_LINE_COMMENT: line length of 107 exceeds 100 columns #3177: FILE: drivers/common/idpf/siov_regs.h:29: +#define VDEV_QTX_COMPL_TAIL_START 0x1900000 /* Begin at offset of 25MB for 2k Tx completion queues */ WARNING:LONG_LINE_COMMENT: line length of 115 exceeds 100 columns #3178: FILE: drivers/common/idpf/siov_regs.h:30: +#define VDEV_QTX_COMPL_TAIL(_i) (VDEV_QTX_COMPL_TAIL_START + ((_i) * 0x1000)) /* 2k Tx completion queues */ WARNING:TYPO_SPELLING: 'accomdate' may be misspelled - perhaps 'accommodate'? #3182: FILE: drivers/common/idpf/siov_regs.h:34: +#define VDEV_INT_DYN_START (VDEV_INT_DYN_CTL01 + 0x1000) /* Begin at offset of 33MB + 4k to accomdate CTL01 register */ WARNING:LONG_LINE_COMMENT: line length of 132 exceeds 100 columns #3182: FILE: drivers/common/idpf/siov_regs.h:34: +#define VDEV_INT_DYN_START (VDEV_INT_DYN_CTL01 + 0x1000) /* Begin at offset of 33MB + 4k to accomdate CTL01 register */ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #3716: FILE: drivers/common/idpf/virtchnl.h:503: +^IVIRTCHNL_RXDID_16_COMMS_GENERIC ^I= 16,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #3717: FILE: drivers/common/idpf/virtchnl.h:504: +^IVIRTCHNL_RXDID_17_COMMS_AUX_VLAN ^I= 17,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #3718: FILE: drivers/common/idpf/virtchnl.h:505: +^IVIRTCHNL_RXDID_18_COMMS_AUX_IPV4 ^I= 18,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #3719: FILE: drivers/common/idpf/virtchnl.h:506: +^IVIRTCHNL_RXDID_19_COMMS_AUX_IPV6 ^I= 19,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #3720: FILE: drivers/common/idpf/virtchnl.h:507: +^IVIRTCHNL_RXDID_20_COMMS_AUX_FLOW ^I= 20,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #3721: FILE: drivers/common/idpf/virtchnl.h:508: +^IVIRTCHNL_RXDID_21_COMMS_AUX_TCP ^I= 21,$ WARNING:SPACE_BEFORE_TAB: please, no space before tabs #4581: FILE: drivers/common/idpf/virtchnl.h:1368: +^Is32 ^Iflow_type;$ ERROR:CODE_INDENT: code indent should use tabs where possible #6115: FILE: drivers/common/idpf/virtchnl2.h:30: + { virtchnl2_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #6115: FILE: drivers/common/idpf/virtchnl2.h:30: + { virtchnl2_static_assert_##X = (n)/((sizeof(struct X) == (n)) ? 1 : 0) }$ ERROR:CODE_INDENT: code indent should use tabs where possible #6117: FILE: drivers/common/idpf/virtchnl2.h:32: + { virtchnl2_static_assert_##X = (n)/((sizeof(union X) == (n)) ? 1 : 0) }$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #6117: FILE: drivers/common/idpf/virtchnl2.h:32: + { virtchnl2_static_assert_##X = (n)/((sizeof(union X) == (n)) ? 1 : 0) }$ WARNING:TYPO_SPELLING: 'upto' may be misspelled - perhaps 'up to'? #6504: FILE: drivers/common/idpf/virtchnl2.h:419: +/* protocol ids upto 32767 are reserved for AVF use */ ERROR:CODE_INDENT: code indent should use tabs where possible #6525: FILE: drivers/common/idpf/virtchnl2.h:440: + u32 major;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #6525: FILE: drivers/common/idpf/virtchnl2.h:440: + u32 major;$ ERROR:CODE_INDENT: code indent should use tabs where possible #6526: FILE: drivers/common/idpf/virtchnl2.h:441: + u32 minor;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #6526: FILE: drivers/common/idpf/virtchnl2.h:441: + u32 minor;$ WARNING:TYPO_SPELLING: 'trasmit' may be misspelled - perhaps 'transmit'? #6728: FILE: drivers/common/idpf/virtchnl2.h:643: + /* valid only if queue model is split and type is trasmit queue. Used ERROR:CODE_INDENT: code indent should use tabs where possible #7246: FILE: drivers/common/idpf/virtchnl2.h:1161: + __le32 vport_id;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7246: FILE: drivers/common/idpf/virtchnl2.h:1161: + __le32 vport_id;$ ERROR:CODE_INDENT: code indent should use tabs where possible #7248: FILE: drivers/common/idpf/virtchnl2.h:1163: + __le16 flags;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7248: FILE: drivers/common/idpf/virtchnl2.h:1163: + __le16 flags;$ ERROR:CODE_INDENT: code indent should use tabs where possible #7537: FILE: drivers/common/idpf/virtchnl2.h:1452: + default:$ ERROR:CODE_INDENT: code indent should use tabs where possible #7538: FILE: drivers/common/idpf/virtchnl2.h:1453: + return VIRTCHNL2_STATUS_ERR_PARAM;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #7538: FILE: drivers/common/idpf/virtchnl2.h:1453: + return VIRTCHNL2_STATUS_ERR_PARAM;$ WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #7833: FILE: drivers/common/idpf/virtchnl2_lan_desc.h:280: +/* splitq buf + | 16| 0| WARNING:TYPO_SPELLING: 'adresss' may be misspelled - perhaps 'address'? #7837: FILE: drivers/common/idpf/virtchnl2_lan_desc.h:284: + | Rx packet buffer adresss | WARNING:TYPO_SPELLING: 'adresss' may be misspelled - perhaps 'address'? #7839: FILE: drivers/common/idpf/virtchnl2_lan_desc.h:286: + | Rx header buffer adresss | WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines #7857: FILE: drivers/common/idpf/virtchnl2_lan_desc.h:304: +/* singleq buf + | 0| WARNING:TYPO_SPELLING: 'adresss' may be misspelled - perhaps 'address'? #7859: FILE: drivers/common/idpf/virtchnl2_lan_desc.h:306: + | Rx packet buffer adresss | WARNING:TYPO_SPELLING: 'adresss' may be misspelled - perhaps 'address'? #7861: FILE: drivers/common/idpf/virtchnl2_lan_desc.h:308: + | Rx header buffer adresss | WARNING:TYPO_SPELLING: 'caculation' may be misspelled - perhaps 'calculation'? #8718: FILE: drivers/common/idpf/virtchnl_inline_ipsec.h:553: + /* Only for msg length caculation of response to VF in case of total: 13 errors, 72 warnings, 8500 lines checked Warning in drivers/common/idpf/idpf_osdep.h: Using compiler attribute directly