From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 802ACA09E5
	for <public@inbox.dpdk.org>; Wed, 19 Oct 2022 18:29:29 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7D1DE4280C;
	Wed, 19 Oct 2022 18:29:29 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 5DE2B410D2
 for <test-report@dpdk.org>; Wed, 19 Oct 2022 18:29:28 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 574A8120778; Wed, 19 Oct 2022 18:29:28 +0200 (CEST)
Subject: |WARNING| pw118629 [PATCH v4 11/18] net/mlx5: add HW steering VLAN
 push, pop and VID modify flow actions
In-Reply-To: <20221019162528.11045-12-suanmingm@nvidia.com>
References: <20221019162528.11045-12-suanmingm@nvidia.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Suanming Mou <suanmingm@nvidia.com>
Message-Id: <20221019162928.574A8120778@dpdk.org>
Date: Wed, 19 Oct 2022 18:29:28 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/118629

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects?
#509: FILE: drivers/net/mlx5/mlx5_flow_hw.c:3062:
+#define X_FIELD(ptr, t, f) (((ptr)->conf) && ((t *)((ptr)->conf))->f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 't' may be better as '(t)' to avoid precedence issues
#509: FILE: drivers/net/mlx5/mlx5_flow_hw.c:3062:
+#define X_FIELD(ptr, t, f) (((ptr)->conf) && ((t *)((ptr)->conf))->f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#509: FILE: drivers/net/mlx5/mlx5_flow_hw.c:3062:
+#define X_FIELD(ptr, t, f) (((ptr)->conf) && ((t *)((ptr)->conf))->f)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#860: FILE: drivers/net/mlx5/mlx5_flow_hw.c:5194:
+	if (priv->sh->config.dv_esw_en && priv->master) {

total: 0 errors, 1 warnings, 3 checks, 671 lines checked