automatic DPDK test reports
 help / color / mirror / Atom feed
From: dpdklab@iol.unh.edu
To: test-report@dpdk.org
Cc: dpdk-test-reports@iol.unh.edu
Subject: |WARNING| pw118557 [PATCH] [v2] net/bonding: fix flow flush order on bonded device close
Date: Wed, 19 Oct 2022 13:18:23 -0400 (EDT)	[thread overview]
Message-ID: <20221019171823.E5227456@noxus.dpdklab.iol.unh.edu> (raw)

[-- Attachment #1: Type: text/plain, Size: 1518 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/118557

_apply patch failure_

Submitter: Ivan Malov <Ivan.Malov@oktetlabs.ru>
Date: Wednesday, October 19 2022 11:18:05 
Applied on: CommitID:a74b1b25136a592c275afbfa6b70771469750aee
Apply patch set 118557 failed:

Checking patch drivers/net/bonding/rte_eth_bond_pmd.c...
error: while searching for:
	int skipped = 0;
	struct rte_flow_error ferror;

	while (internals->slave_count != skipped) {
		uint16_t port_id = internals->slaves[skipped].port_id;


error: patch failed: drivers/net/bonding/rte_eth_bond_pmd.c:2156
error: while searching for:
			skipped++;
		}
	}
	bond_flow_ops.flush(dev, &ferror);
}

int

error: patch failed: drivers/net/bonding/rte_eth_bond_pmd.c:2173
Applying patch drivers/net/bonding/rte_eth_bond_pmd.c with 2 rejects...
Rejected hunk #1.
Rejected hunk #2.
diff a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c	(rejected hunks)
@@ -2156,6 +2156,9 @@ bond_ethdev_cfg_cleanup(struct rte_eth_dev *dev)
 	int skipped = 0;
 	struct rte_flow_error ferror;
 
+	/* Flush flows in all back-end devices before removing them */
+	bond_flow_ops.flush(dev, &ferror);
+
 	while (internals->slave_count != skipped) {
 		uint16_t port_id = internals->slaves[skipped].port_id;
 
@@ -2173,7 +2176,6 @@ bond_ethdev_cfg_cleanup(struct rte_eth_dev *dev)
 			skipped++;
 		}
 	}
-	bond_flow_ops.flush(dev, &ferror);
 }
 
 int

https://lab.dpdk.org/results/dashboard/patchsets/24068/

UNH-IOL DPDK Community Lab

                 reply	other threads:[~2022-10-19 17:18 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221019171823.E5227456@noxus.dpdklab.iol.unh.edu \
    --to=dpdklab@iol.unh.edu \
    --cc=dpdk-test-reports@iol.unh.edu \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).