From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Kumara Parameshwaran <kumaraparamesh92@gmail.com>
Subject: |WARNING| pw118786 [PATCH] gro : ipv6 changes to support GRO for TCP/ipv6
Date: Thu, 20 Oct 2022 14:13:43 +0200 (CEST) [thread overview]
Message-ID: <20221020121343.C161C120778@dpdk.org> (raw)
In-Reply-To: <20221020121309.14737-1-kparameshwar@kparameshwa-a02.vmware.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/118786
_coding style issues_
ERROR:TRAILING_WHITESPACE: trailing whitespace
#242: FILE: lib/gro/gro_tcp.h:124:
+^Iiph_orig = (char *)(rte_pktmbuf_mtod(pkt_orig, char *) + $
ERROR:CODE_INDENT: code indent should use tabs where possible
#243: FILE: lib/gro/gro_tcp.h:125:
+ l2_offset + pkt_orig->l2_len);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#243: FILE: lib/gro/gro_tcp.h:125:
+ l2_offset + pkt_orig->l2_len);$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#730: FILE: lib/gro/gro_tcp6.c:229:
+^I/* $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#731: FILE: lib/gro/gro_tcp6.c:230:
+^I * Trim the tail padding bytes. The IPv6 header is fixed to $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#732: FILE: lib/gro/gro_tcp6.c:231:
+^I * 40 bytes unlike IPv4 that is variable. The length in the IPv6 header $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#733: FILE: lib/gro/gro_tcp6.c:232:
+^I * contains only length of TCP Header + TCP Payload, whereas IPv4 header contains $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#750: FILE: lib/gro/gro_tcp6.c:249:
+ memcpy(&key.src_addr[0], &ipv6_hdr->src_addr, sizeof(key.src_addr));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#751: FILE: lib/gro/gro_tcp6.c:250:
+ memcpy(&key.dst_addr[0], &ipv6_hdr->dst_addr, sizeof(key.dst_addr));$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#763: FILE: lib/gro/gro_tcp6.c:262:
+^I^I^I^I/* $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#764: FILE: lib/gro/gro_tcp6.c:263:
+^I^I^I^I * IP version (4) Traffic Class (8) Flow Label (20) $
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#766: FILE: lib/gro/gro_tcp6.c:265:
+ * All fields except Traffic class should be same
+ */
WARNING:BRACES: braces {} are not necessary for single statement blocks
#768: FILE: lib/gro/gro_tcp6.c:267:
+ if (vtc_flow_diff & htonl(0xF00FFFFF)) {
+ continue;
+ }
ERROR:CODE_INDENT: code indent should use tabs where possible
#813: FILE: lib/gro/gro_tcp6.c:312:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#813: FILE: lib/gro/gro_tcp6.c:312:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#910: FILE: lib/gro/gro_tcp6.h:15:
+ uint8_t src_addr[16];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#911: FILE: lib/gro/gro_tcp6.h:16:
+ uint8_t dst_addr[16];$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1042: FILE: lib/gro/gro_tcp6.h:147:
+ return (!memcmp(&k1, &k2, sizeof(struct tcp6_flow_key)));$
WARNING:MISSING_EOF_NEWLINE: adding a line without newline at end of file
#1045: FILE: lib/gro/gro_tcp6.h:150:
+#endif
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1193: FILE: lib/gro/rte_gro.c:304:
+^I^I} else if (IS_IPV6_TCP_PKT(pkts[i]->packet_type) && $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1234: FILE: lib/gro/rte_gro.c:350:
+^I^I^Ii += gro_tcp6_tbl_timeout_flush(&tcp6_tbl, 0, $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1254: FILE: lib/gro/rte_gro.c:371:
+^I^I^I^I^IRTE_GRO_TCP_IPV4 | RTE_GRO_TCP_IPV6 | $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1279: FILE: lib/gro/rte_gro.c:415:
+^I^I} else if (IS_IPV6_TCP_PKT(pkts[i]->packet_type) && $
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1281: FILE: lib/gro/rte_gro.c:417:
+^I^I^Iif (gro_tcp6_reassemble(pkts[i], tcp6_tbl, $
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#1285: FILE: lib/gro/rte_gro.c:421:
+ }
+ else
total: 15 errors, 10 warnings, 1132 lines checked
next parent reply other threads:[~2022-10-20 12:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221020121309.14737-1-kparameshwar@kparameshwa-a02.vmware.com>
2022-10-20 12:13 ` checkpatch [this message]
2022-10-20 13:39 ` |SUCCESS| " 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221020121343.C161C120778@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=kumaraparamesh92@gmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).