automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Suanming Mou <suanmingm@nvidia.com>
Subject: |WARNING| pw118802 [PATCH v6 11/18] net/mlx5: add HW steering VLAN push, pop and VID modify flow actions
Date: Thu, 20 Oct 2022 17:48:41 +0200 (CEST)	[thread overview]
Message-ID: <20221020154841.50B4B120778@dpdk.org> (raw)
In-Reply-To: <20221020154152.28228-12-suanmingm@nvidia.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/118802

_coding style issues_


CHECK:MACRO_ARG_REUSE: Macro argument reuse 'ptr' - possible side-effects?
#510: FILE: drivers/net/mlx5/mlx5_flow_hw.c:3065:
+#define X_FIELD(ptr, t, f) (((ptr)->conf) && ((t *)((ptr)->conf))->f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 't' may be better as '(t)' to avoid precedence issues
#510: FILE: drivers/net/mlx5/mlx5_flow_hw.c:3065:
+#define X_FIELD(ptr, t, f) (((ptr)->conf) && ((t *)((ptr)->conf))->f)

CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'f' may be better as '(f)' to avoid precedence issues
#510: FILE: drivers/net/mlx5/mlx5_flow_hw.c:3065:
+#define X_FIELD(ptr, t, f) (((ptr)->conf) && ((t *)((ptr)->conf))->f)

WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'?
#861: FILE: drivers/net/mlx5/mlx5_flow_hw.c:5197:
+	if (priv->sh->config.dv_esw_en && priv->master) {

total: 0 errors, 1 warnings, 3 checks, 671 lines checked

           reply	other threads:[~2022-10-20 15:48 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20221020154152.28228-12-suanmingm@nvidia.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221020154841.50B4B120778@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=suanmingm@nvidia.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).