From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: |WARNING| pw119121 [PATCH 4/8] ethdev: use GRE protocol struct for flow matching
Date: Tue, 25 Oct 2022 23:47:18 +0200 (CEST) [thread overview]
Message-ID: <20221025214718.0E4DF1223D0@dpdk.org> (raw)
In-Reply-To: <20221025214410.715864-5-thomas@monjalon.net>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/119121
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.k'
#293: FILE: drivers/net/mlx5/mlx5_flow.c:2990:
+ if (gre_spec && (gre_mask->hdr.k) && !(gre_spec->hdr.k))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.c'
#303: FILE: drivers/net/mlx5/mlx5_flow.c:3065:
+ if (gre_spec && (gre_mask->hdr.c) && !(gre_spec->hdr.c))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.k'
#311: FILE: drivers/net/mlx5/mlx5_flow.c:3071:
+ if (gre_spec && (gre_mask->hdr.k) && !(gre_spec->hdr.k))
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.s'
#318: FILE: drivers/net/mlx5/mlx5_flow.c:3076:
+ if (gre_spec && (gre_mask->hdr.s) && !(gre_spec->hdr.s))
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#354: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9022:
+ gre_crks_rsvd0_ver_m.value = rte_be_to_cpu_16(*(const uint16_t*)&gre_m->hdr);
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#355: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9023:
+ gre_crks_rsvd0_ver_v.value = rte_be_to_cpu_16(*(const uint16_t*)&gre_v->hdr);
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#387: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9115:
+ c_rsvd0_ver_v = *(const uint16_t*)&gre_v->hdr;
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#388: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9116:
+ c_rsvd0_ver_m = *(const uint16_t*)&gre_m->hdr;
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#423: FILE: drivers/net/mlx5/mlx5_flow_verbs.c:962:
+ tunnel.val.c_ks_res0_ver = *(const uint16_t*)&spec->hdr;
ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#425: FILE: drivers/net/mlx5/mlx5_flow_verbs.c:964:
+ tunnel.mask.c_ks_res0_ver = *(const uint16_t*)&mask->hdr;
total: 6 errors, 0 warnings, 285 lines checked
parent reply other threads:[~2022-10-25 21:47 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20221025214410.715864-5-thomas@monjalon.net>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221025214718.0E4DF1223D0@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).