From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7FA45A0544
	for <public@inbox.dpdk.org>; Tue, 25 Oct 2022 23:47:22 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 7D17842C5B;
	Tue, 25 Oct 2022 23:47:22 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 1335D410D2
 for <test-report@dpdk.org>; Tue, 25 Oct 2022 23:47:18 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 0E4DF1223D0; Tue, 25 Oct 2022 23:47:18 +0200 (CEST)
Subject: |WARNING| pw119121 [PATCH 4/8] ethdev: use GRE protocol struct for
 flow matching
In-Reply-To: <20221025214410.715864-5-thomas@monjalon.net>
References: <20221025214410.715864-5-thomas@monjalon.net>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Thomas Monjalon <thomas@monjalon.net>
Message-Id: <20221025214718.0E4DF1223D0@dpdk.org>
Date: Tue, 25 Oct 2022 23:47:18 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/119121

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.k'
#293: FILE: drivers/net/mlx5/mlx5_flow.c:2990:
+	if (gre_spec && (gre_mask->hdr.k) && !(gre_spec->hdr.k))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.c'
#303: FILE: drivers/net/mlx5/mlx5_flow.c:3065:
+		if (gre_spec && (gre_mask->hdr.c) && !(gre_spec->hdr.c))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.k'
#311: FILE: drivers/net/mlx5/mlx5_flow.c:3071:
+		if (gre_spec && (gre_mask->hdr.k) && !(gre_spec->hdr.k))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'gre_mask->hdr.s'
#318: FILE: drivers/net/mlx5/mlx5_flow.c:3076:
+		if (gre_spec && (gre_mask->hdr.s) && !(gre_spec->hdr.s))

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#354: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9022:
+	gre_crks_rsvd0_ver_m.value = rte_be_to_cpu_16(*(const uint16_t*)&gre_m->hdr);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#355: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9023:
+	gre_crks_rsvd0_ver_v.value = rte_be_to_cpu_16(*(const uint16_t*)&gre_v->hdr);

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#387: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9115:
+	c_rsvd0_ver_v = *(const uint16_t*)&gre_v->hdr;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#388: FILE: drivers/net/mlx5/mlx5_flow_dv.c:9116:
+	c_rsvd0_ver_m = *(const uint16_t*)&gre_m->hdr;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#423: FILE: drivers/net/mlx5/mlx5_flow_verbs.c:962:
+	tunnel.val.c_ks_res0_ver = *(const uint16_t*)&spec->hdr;

ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#425: FILE: drivers/net/mlx5/mlx5_flow_verbs.c:964:
+	tunnel.mask.c_ks_res0_ver = *(const uint16_t*)&mask->hdr;

total: 6 errors, 0 warnings, 285 lines checked