automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Megha Ajmera <megha.ajmera@intel.com>
Subject: |WARNING| pw119255 [PATCH v5 3/3] sched: support for 100G+ rates in subport/pipe config
Date: Fri, 28 Oct 2022 10:14:59 +0200 (CEST)	[thread overview]
Message-ID: <20221028081459.7368D122B86@dpdk.org> (raw)
In-Reply-To: <20221028080946.676201-3-megha.ajmera@intel.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/119255

_coding style issues_


ERROR:SPACING: space required before the open parenthesis '('
#91: FILE: examples/qos_sched/cfg_file.c:31:
+	if(!entry || !val)

WARNING:BRACES: braces {} are not necessary for single statement blocks
#97: FILE: examples/qos_sched/cfg_file.c:37:
+	if (errno == EINVAL || errno == ERANGE || *endptr != '') {
+		return -EINVAL;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#248: FILE: examples/qos_sched/cfg_file.c:199:
+		if (ret) {
+			return ret;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#384: FILE: examples/qos_sched/init.c:289:
+	if (cfg_load_port(file, &port_params)) {
+		rte_exit(EXIT_FAILURE, "Invalid port configuration
");
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#387: FILE: examples/qos_sched/init.c:292:
+	if (cfg_load_subport(file, subport_params)) {
+		rte_exit (EXIT_FAILURE, "Invalid subport configuration
");
+	}

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#388: FILE: examples/qos_sched/init.c:293:
+		rte_exit (EXIT_FAILURE, "Invalid subport configuration
");

WARNING:BRACES: braces {} are not necessary for single statement blocks
#390: FILE: examples/qos_sched/init.c:295:
+	if (cfg_load_subport_profile(file, subport_profile)) {
+		rte_exit(EXIT_FAILURE, "Invalid subport profile configuration
");
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#393: FILE: examples/qos_sched/init.c:298:
+	if (cfg_load_pipe(file, pipe_profiles)) {
+		rte_exit(EXIT_FAILURE, "Invalid pipe profile configuration
");
+	}

total: 1 errors, 7 warnings, 300 lines checked

       reply	other threads:[~2022-10-28  8:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20221028080946.676201-3-megha.ajmera@intel.com>
2022-10-28  8:14 ` checkpatch [this message]
2022-10-28  9:18 ` |SUCCESS| " 0-day Robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221028081459.7368D122B86@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=megha.ajmera@intel.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).