From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 900F2A0542
	for <public@inbox.dpdk.org>; Fri, 28 Oct 2022 10:15:01 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8844F40696;
	Fri, 28 Oct 2022 10:15:01 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 8136A40041
 for <test-report@dpdk.org>; Fri, 28 Oct 2022 10:14:59 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 7368D122B86; Fri, 28 Oct 2022 10:14:59 +0200 (CEST)
Subject: |WARNING| pw119255 [PATCH v5 3/3] sched: support for 100G+ rates in
 subport/pipe config
In-Reply-To: <20221028080946.676201-3-megha.ajmera@intel.com>
References: <20221028080946.676201-3-megha.ajmera@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Megha Ajmera <megha.ajmera@intel.com>
Message-Id: <20221028081459.7368D122B86@dpdk.org>
Date: Fri, 28 Oct 2022 10:14:59 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/119255

_coding style issues_


ERROR:SPACING: space required before the open parenthesis '('
#91: FILE: examples/qos_sched/cfg_file.c:31:
+	if(!entry || !val)

WARNING:BRACES: braces {} are not necessary for single statement blocks
#97: FILE: examples/qos_sched/cfg_file.c:37:
+	if (errno == EINVAL || errno == ERANGE || *endptr != '') {
+		return -EINVAL;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#248: FILE: examples/qos_sched/cfg_file.c:199:
+		if (ret) {
+			return ret;
+		}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#384: FILE: examples/qos_sched/init.c:289:
+	if (cfg_load_port(file, &port_params)) {
+		rte_exit(EXIT_FAILURE, "Invalid port configuration
");
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#387: FILE: examples/qos_sched/init.c:292:
+	if (cfg_load_subport(file, subport_params)) {
+		rte_exit (EXIT_FAILURE, "Invalid subport configuration
");
+	}

WARNING:SPACING: space prohibited between function name and open parenthesis '('
#388: FILE: examples/qos_sched/init.c:293:
+		rte_exit (EXIT_FAILURE, "Invalid subport configuration
");

WARNING:BRACES: braces {} are not necessary for single statement blocks
#390: FILE: examples/qos_sched/init.c:295:
+	if (cfg_load_subport_profile(file, subport_profile)) {
+		rte_exit(EXIT_FAILURE, "Invalid subport profile configuration
");
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#393: FILE: examples/qos_sched/init.c:298:
+	if (cfg_load_pipe(file, pipe_profiles)) {
+		rte_exit(EXIT_FAILURE, "Invalid pipe profile configuration
");
+	}

total: 1 errors, 7 warnings, 300 lines checked