From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: David Miller <dmiller423@gmail.com>
Subject: |WARNING| pw119265 [PATCH] Add support for IBM Z s390x
Date: Fri, 28 Oct 2022 23:54:10 +0200 (CEST) [thread overview]
Message-ID: <20221028215410.CDFAF122B86@dpdk.org> (raw)
In-Reply-To: <20221028215240.103365-1-dmiller423@gmail.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/119265
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#205: FILE: app/test-pmd/config.c:248:
+ __uint128_t diff_pkts_rx, diff_pkts_tx, diff_bytes_rx, diff_bytes_tx,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#206: FILE: app/test-pmd/config.c:249:
+ diff_ns;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#206: FILE: app/test-pmd/config.c:249:
+ diff_ns;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#207: FILE: app/test-pmd/config.c:250:
+ __uint128_t mpps_rx, mpps_tx, mbps_rx, mbps_tx;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#218: FILE: app/test-pmd/config.c:305:
+ printf(" Rx-pps: %12llu Rx-bps: %12llu
Tx-pps: %12llu Tx-bps: %12llu
",$
WARNING:QUOTED_WHITESPACE_BEFORE_NEWLINE: unnecessary whitespace before a quoted newline
#218: FILE: app/test-pmd/config.c:305:
+ printf(" Rx-pps: %12llu Rx-bps: %12llu
Tx-pps: %12llu Tx-bps: %12llu
",
ERROR:CODE_INDENT: code indent should use tabs where possible
#219: FILE: app/test-pmd/config.c:306:
+ (unsigned long long) mpps_rx, (unsigned long long) mbps_rx * 8,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#219: FILE: app/test-pmd/config.c:306:
+ (unsigned long long) mpps_rx, (unsigned long long) mbps_rx * 8,$
ERROR:CODE_INDENT: code indent should use tabs where possible
#220: FILE: app/test-pmd/config.c:307:
+ (unsigned long long) mpps_tx, (unsigned long long) mbps_tx * 8);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#220: FILE: app/test-pmd/config.c:307:
+ (unsigned long long) mpps_tx, (unsigned long long) mbps_tx * 8);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#232: FILE: app/test/test_acl.c:354:
+ RTE_ACL_CLASSIFY_S390X,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#232: FILE: app/test/test_acl.c:354:
+ RTE_ACL_CLASSIFY_S390X,$
ERROR:SPACING: space required after that ',' (ctx:VxV)
#335: FILE: app/test/test_cmdline_ipaddr.c:25:
+#define IP4(a,b,c,d) {((uint32_t)(((a) & 0xff) << 24) | \
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#335: FILE: app/test/test_cmdline_ipaddr.c:25:
+#define IP4(a,b,c,d) {((uint32_t)(((a) & 0xff) << 24) | \
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#335: FILE: app/test/test_cmdline_ipaddr.c:25:
+#define IP4(a,b,c,d) {((uint32_t)(((a) & 0xff) << 24) | \
^
ERROR:CODE_INDENT: code indent should use tabs where possible
#363: FILE: app/test/test_cmdline_num.c:443:
+ switch (type) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#363: FILE: app/test/test_cmdline_num.c:443:
+ switch (type) {$
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#363: FILE: app/test/test_cmdline_num.c:443:
+ switch (type) {
+ case RTE_UINT8:
[...]
+ case RTE_UINT16:
[...]
+ case RTE_UINT32:
[...]
+ case RTE_INT8:
[...]
+ case RTE_INT16:
[...]
+ case RTE_INT32:
[...]
+ default:
ERROR:CODE_INDENT: code indent should use tabs where possible
#364: FILE: app/test/test_cmdline_num.c:444:
+ case RTE_UINT8:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#364: FILE: app/test/test_cmdline_num.c:444:
+ case RTE_UINT8:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#365: FILE: app/test/test_cmdline_num.c:445:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#365: FILE: app/test/test_cmdline_num.c:445:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#366: FILE: app/test/test_cmdline_num.c:446:
+ uint8_t *temp = (uint8_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#366: FILE: app/test/test_cmdline_num.c:446:
+ uint8_t *temp = (uint8_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#367: FILE: app/test/test_cmdline_num.c:447:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#367: FILE: app/test/test_cmdline_num.c:447:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#368: FILE: app/test/test_cmdline_num.c:448:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#368: FILE: app/test/test_cmdline_num.c:448:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#369: FILE: app/test/test_cmdline_num.c:449:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#369: FILE: app/test/test_cmdline_num.c:449:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#370: FILE: app/test/test_cmdline_num.c:450:
+ case RTE_UINT16:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#370: FILE: app/test/test_cmdline_num.c:450:
+ case RTE_UINT16:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#371: FILE: app/test/test_cmdline_num.c:451:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#371: FILE: app/test/test_cmdline_num.c:451:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#372: FILE: app/test/test_cmdline_num.c:452:
+ uint16_t *temp = (uint16_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#372: FILE: app/test/test_cmdline_num.c:452:
+ uint16_t *temp = (uint16_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#373: FILE: app/test/test_cmdline_num.c:453:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#373: FILE: app/test/test_cmdline_num.c:453:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#374: FILE: app/test/test_cmdline_num.c:454:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#374: FILE: app/test/test_cmdline_num.c:454:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#375: FILE: app/test/test_cmdline_num.c:455:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#375: FILE: app/test/test_cmdline_num.c:455:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#376: FILE: app/test/test_cmdline_num.c:456:
+ case RTE_UINT32:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#376: FILE: app/test/test_cmdline_num.c:456:
+ case RTE_UINT32:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#377: FILE: app/test/test_cmdline_num.c:457:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#377: FILE: app/test/test_cmdline_num.c:457:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#378: FILE: app/test/test_cmdline_num.c:458:
+ uint32_t *temp = (uint32_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#378: FILE: app/test/test_cmdline_num.c:458:
+ uint32_t *temp = (uint32_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#379: FILE: app/test/test_cmdline_num.c:459:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#379: FILE: app/test/test_cmdline_num.c:459:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#380: FILE: app/test/test_cmdline_num.c:460:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#380: FILE: app/test/test_cmdline_num.c:460:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#381: FILE: app/test/test_cmdline_num.c:461:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#381: FILE: app/test/test_cmdline_num.c:461:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#382: FILE: app/test/test_cmdline_num.c:462:
+ case RTE_INT8:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#382: FILE: app/test/test_cmdline_num.c:462:
+ case RTE_INT8:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#383: FILE: app/test/test_cmdline_num.c:463:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#383: FILE: app/test/test_cmdline_num.c:463:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#384: FILE: app/test/test_cmdline_num.c:464:
+ int8_t *temp = (int8_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#384: FILE: app/test/test_cmdline_num.c:464:
+ int8_t *temp = (int8_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#385: FILE: app/test/test_cmdline_num.c:465:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#385: FILE: app/test/test_cmdline_num.c:465:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#386: FILE: app/test/test_cmdline_num.c:466:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#386: FILE: app/test/test_cmdline_num.c:466:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#387: FILE: app/test/test_cmdline_num.c:467:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#387: FILE: app/test/test_cmdline_num.c:467:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#388: FILE: app/test/test_cmdline_num.c:468:
+ case RTE_INT16:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#388: FILE: app/test/test_cmdline_num.c:468:
+ case RTE_INT16:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#389: FILE: app/test/test_cmdline_num.c:469:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#389: FILE: app/test/test_cmdline_num.c:469:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#390: FILE: app/test/test_cmdline_num.c:470:
+ int16_t *temp = (int16_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#390: FILE: app/test/test_cmdline_num.c:470:
+ int16_t *temp = (int16_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#391: FILE: app/test/test_cmdline_num.c:471:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#391: FILE: app/test/test_cmdline_num.c:471:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#392: FILE: app/test/test_cmdline_num.c:472:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#392: FILE: app/test/test_cmdline_num.c:472:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#393: FILE: app/test/test_cmdline_num.c:473:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#393: FILE: app/test/test_cmdline_num.c:473:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#394: FILE: app/test/test_cmdline_num.c:474:
+ case RTE_INT32:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#394: FILE: app/test/test_cmdline_num.c:474:
+ case RTE_INT32:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#395: FILE: app/test/test_cmdline_num.c:475:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#395: FILE: app/test/test_cmdline_num.c:475:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#396: FILE: app/test/test_cmdline_num.c:476:
+ int32_t *temp = (int32_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#396: FILE: app/test/test_cmdline_num.c:476:
+ int32_t *temp = (int32_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#397: FILE: app/test/test_cmdline_num.c:477:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#397: FILE: app/test/test_cmdline_num.c:477:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#398: FILE: app/test/test_cmdline_num.c:478:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#398: FILE: app/test/test_cmdline_num.c:478:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#399: FILE: app/test/test_cmdline_num.c:479:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#399: FILE: app/test/test_cmdline_num.c:479:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#400: FILE: app/test/test_cmdline_num.c:480:
+ default:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#401: FILE: app/test/test_cmdline_num.c:481:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#401: FILE: app/test/test_cmdline_num.c:481:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#402: FILE: app/test/test_cmdline_num.c:482:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#402: FILE: app/test/test_cmdline_num.c:482:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#420: FILE: app/test/test_cmdline_num.c:528:
+ switch (type) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#420: FILE: app/test/test_cmdline_num.c:528:
+ switch (type) {$
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#420: FILE: app/test/test_cmdline_num.c:528:
+ switch (type) {
+ case RTE_INT8:
[...]
+ case RTE_INT16:
[...]
+ case RTE_INT32:
[...]
+ default:
ERROR:CODE_INDENT: code indent should use tabs where possible
#451: FILE: app/test/test_cmdline_num.c:588:
+ switch (type) {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#451: FILE: app/test/test_cmdline_num.c:588:
+ switch (type) {$
ERROR:SWITCH_CASE_INDENT_LEVEL: switch and case should be at the same indent
#451: FILE: app/test/test_cmdline_num.c:588:
+ switch (type) {
+ case RTE_UINT8:
[...]
+ case RTE_UINT16:
[...]
+ case RTE_UINT32:
[...]
+ case RTE_INT8:
[...]
+ case RTE_INT16:
[...]
+ case RTE_INT32:
[...]
+ default:
ERROR:CODE_INDENT: code indent should use tabs where possible
#452: FILE: app/test/test_cmdline_num.c:589:
+ case RTE_UINT8:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#452: FILE: app/test/test_cmdline_num.c:589:
+ case RTE_UINT8:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#453: FILE: app/test/test_cmdline_num.c:590:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#453: FILE: app/test/test_cmdline_num.c:590:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#454: FILE: app/test/test_cmdline_num.c:591:
+ uint8_t *temp = (uint8_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#454: FILE: app/test/test_cmdline_num.c:591:
+ uint8_t *temp = (uint8_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#455: FILE: app/test/test_cmdline_num.c:592:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#455: FILE: app/test/test_cmdline_num.c:592:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#456: FILE: app/test/test_cmdline_num.c:593:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#456: FILE: app/test/test_cmdline_num.c:593:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#457: FILE: app/test/test_cmdline_num.c:594:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#457: FILE: app/test/test_cmdline_num.c:594:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#458: FILE: app/test/test_cmdline_num.c:595:
+ case RTE_UINT16:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#458: FILE: app/test/test_cmdline_num.c:595:
+ case RTE_UINT16:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#459: FILE: app/test/test_cmdline_num.c:596:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#459: FILE: app/test/test_cmdline_num.c:596:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#460: FILE: app/test/test_cmdline_num.c:597:
+ uint16_t *temp = (uint16_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#460: FILE: app/test/test_cmdline_num.c:597:
+ uint16_t *temp = (uint16_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#461: FILE: app/test/test_cmdline_num.c:598:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#461: FILE: app/test/test_cmdline_num.c:598:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#462: FILE: app/test/test_cmdline_num.c:599:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#462: FILE: app/test/test_cmdline_num.c:599:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#463: FILE: app/test/test_cmdline_num.c:600:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#463: FILE: app/test/test_cmdline_num.c:600:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#464: FILE: app/test/test_cmdline_num.c:601:
+ case RTE_UINT32:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#464: FILE: app/test/test_cmdline_num.c:601:
+ case RTE_UINT32:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#465: FILE: app/test/test_cmdline_num.c:602:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#465: FILE: app/test/test_cmdline_num.c:602:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#466: FILE: app/test/test_cmdline_num.c:603:
+ uint32_t *temp = (uint32_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#466: FILE: app/test/test_cmdline_num.c:603:
+ uint32_t *temp = (uint32_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#467: FILE: app/test/test_cmdline_num.c:604:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#467: FILE: app/test/test_cmdline_num.c:604:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#468: FILE: app/test/test_cmdline_num.c:605:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#468: FILE: app/test/test_cmdline_num.c:605:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#469: FILE: app/test/test_cmdline_num.c:606:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#469: FILE: app/test/test_cmdline_num.c:606:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#470: FILE: app/test/test_cmdline_num.c:607:
+ case RTE_INT8:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#470: FILE: app/test/test_cmdline_num.c:607:
+ case RTE_INT8:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#471: FILE: app/test/test_cmdline_num.c:608:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#471: FILE: app/test/test_cmdline_num.c:608:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#472: FILE: app/test/test_cmdline_num.c:609:
+ int8_t *temp = (int8_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#472: FILE: app/test/test_cmdline_num.c:609:
+ int8_t *temp = (int8_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#473: FILE: app/test/test_cmdline_num.c:610:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#473: FILE: app/test/test_cmdline_num.c:610:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#474: FILE: app/test/test_cmdline_num.c:611:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#474: FILE: app/test/test_cmdline_num.c:611:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#475: FILE: app/test/test_cmdline_num.c:612:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#475: FILE: app/test/test_cmdline_num.c:612:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#476: FILE: app/test/test_cmdline_num.c:613:
+ case RTE_INT16:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#476: FILE: app/test/test_cmdline_num.c:613:
+ case RTE_INT16:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#477: FILE: app/test/test_cmdline_num.c:614:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#477: FILE: app/test/test_cmdline_num.c:614:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#478: FILE: app/test/test_cmdline_num.c:615:
+ int16_t *temp = (int16_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#478: FILE: app/test/test_cmdline_num.c:615:
+ int16_t *temp = (int16_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#479: FILE: app/test/test_cmdline_num.c:616:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#479: FILE: app/test/test_cmdline_num.c:616:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#480: FILE: app/test/test_cmdline_num.c:617:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#480: FILE: app/test/test_cmdline_num.c:617:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#481: FILE: app/test/test_cmdline_num.c:618:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#481: FILE: app/test/test_cmdline_num.c:618:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#482: FILE: app/test/test_cmdline_num.c:619:
+ case RTE_INT32:$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#482: FILE: app/test/test_cmdline_num.c:619:
+ case RTE_INT32:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#483: FILE: app/test/test_cmdline_num.c:620:
+ {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#483: FILE: app/test/test_cmdline_num.c:620:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#484: FILE: app/test/test_cmdline_num.c:621:
+ int32_t *temp = (int32_t *)&result;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#484: FILE: app/test/test_cmdline_num.c:621:
+ int32_t *temp = (int32_t *)&result;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#485: FILE: app/test/test_cmdline_num.c:622:
+ result = *temp;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#485: FILE: app/test/test_cmdline_num.c:622:
+ result = *temp;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#486: FILE: app/test/test_cmdline_num.c:623:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#486: FILE: app/test/test_cmdline_num.c:623:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#487: FILE: app/test/test_cmdline_num.c:624:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#487: FILE: app/test/test_cmdline_num.c:624:
+ }$
ERROR:CODE_INDENT: code indent should use tabs where possible
#488: FILE: app/test/test_cmdline_num.c:625:
+ default:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#489: FILE: app/test/test_cmdline_num.c:626:
+ break;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#489: FILE: app/test/test_cmdline_num.c:626:
+ break;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#490: FILE: app/test/test_cmdline_num.c:627:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#490: FILE: app/test/test_cmdline_num.c:627:
+ }$
WARNING:TYPO_SPELLING: 'daa' may be misspelled - perhaps 'data'?
#533: FILE: app/test/test_hash_functions.c:77:
+ 0x37765e57, 0x6559eb17, 0x49c8a164, 0x18daa0d3,
WARNING:TYPO_SPELLING: 'implemenation' may be misspelled - perhaps 'implementation'?
#712: FILE: drivers/common/mlx5/mlx5_common.h:23:
+/* s390x pci implemenation. */
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#727: FILE: drivers/common/mlx5/mlx5_common.h:369:
+ rte_write64_relaxed(val, uar->db);$
WARNING:REPEATED_WORD: Possible repeated word: 'count'
#1155: FILE: drivers/net/i40e/i40e_rxtx_vec_s390x.c:418:
+ /* the staterr values are not in order, as the count
+ * count of dd bits doesn't care. However, for end of
WARNING:TYPO_SPELLING: 'avaialbe' may be misspelled - perhaps 'available'?
#1185: FILE: drivers/net/i40e/i40e_rxtx_vec_s390x.c:448:
+ /* C.4 calc avaialbe number of desc */
ERROR:CODE_INDENT: code indent should use tabs where possible
#1416: FILE: drivers/net/mlx5/mlx5_rx.c:213:
+ snprintf(mode->info, sizeof(mode->info), "%s", "Vector S390X");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1416: FILE: drivers/net/mlx5/mlx5_rx.c:213:
+ snprintf(mode->info, sizeof(mode->info), "%s", "Vector S390X");$
ERROR:CODE_INDENT: code indent should use tabs where possible
#1425: FILE: drivers/net/mlx5/mlx5_rx.c:225:
+ snprintf(mode->info, sizeof(mode->info), "%s", "MPRQ Vector S390X");$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1425: FILE: drivers/net/mlx5/mlx5_rx.c:225:
+ snprintf(mode->info, sizeof(mode->info), "%s", "MPRQ Vector S390X");$
WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#1439: FILE: drivers/net/mlx5/mlx5_rx.c:326:
+ * to be converted from LE to BE for the logic to work
+ */
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1440: FILE: drivers/net/mlx5/mlx5_rx.c:327:
+ uint16_t cqe_t_le = rte_le_to_cpu_16(cqe->hdr_type_etc);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1441: FILE: drivers/net/mlx5/mlx5_rx.c:328:
+ uint16_t mcqe_t_le;$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 8)
#1450: FILE: drivers/net/mlx5/mlx5_rx.c:334:
+ else {
+ mcqe_t_le = rte_le_to_cpu_16(mcqe->hdr_type);
CHECK:BRACES: Unbalanced braces around else statement
#1450: FILE: drivers/net/mlx5/mlx5_rx.c:334:
+ else {
ERROR:CODE_INDENT: code indent should use tabs where possible
#1451: FILE: drivers/net/mlx5/mlx5_rx.c:335:
+ mcqe_t_le = rte_le_to_cpu_16(mcqe->hdr_type);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1451: FILE: drivers/net/mlx5/mlx5_rx.c:335:
+ mcqe_t_le = rte_le_to_cpu_16(mcqe->hdr_type);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1453: FILE: drivers/net/mlx5/mlx5_rx.c:337:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1482: FILE: examples/l3fwd-acl/main.c:173:
+ {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#1483: FILE: examples/l3fwd-acl/main.c:174:
+ .name = "s390x",$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1483: FILE: examples/l3fwd-acl/main.c:174:
+ .name = "s390x",$
ERROR:CODE_INDENT: code indent should use tabs where possible
#1484: FILE: examples/l3fwd-acl/main.c:175:
+ .alg = RTE_ACL_CLASSIFY_S390X,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1484: FILE: examples/l3fwd-acl/main.c:175:
+ .alg = RTE_ACL_CLASSIFY_S390X,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1485: FILE: examples/l3fwd-acl/main.c:176:
+ }$
ERROR:C99_COMMENTS: do not use C99 // comments
#1667: FILE: examples/l3fwd/l3fwd_s390x.h:11:
+#define vec_sro(a, b) vec_srb(a, (b) << 64) // Vector Shift Right by Octet
WARNING:TYPO_SPELLING: 'signifcant' may be misspelled - perhaps 'significant'?
#1940: FILE: lib/acl/acl_gen.c:365:
+ * is at least signifcant byte.
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1996: FILE: lib/acl/rte_acl.c:159:
+ if (alg == RTE_ACL_CLASSIFY_S390X) {$
ERROR:TRAILING_WHITESPACE: trailing whitespace
#1998: FILE: lib/acl/rte_acl.c:161:
+ if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) $
ERROR:CODE_INDENT: code indent should use tabs where possible
#1998: FILE: lib/acl/rte_acl.c:161:
+ if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) $
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#1998: FILE: lib/acl/rte_acl.c:161:
+ if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128) $
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (8, 24)
#1998: FILE: lib/acl/rte_acl.c:161:
+ if (rte_vect_get_max_simd_bitwidth() >= RTE_VECT_SIMD_128)
+ return 0;
ERROR:CODE_INDENT: code indent should use tabs where possible
#2001: FILE: lib/acl/rte_acl.c:164:
+ return -ENOTSUP;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2001: FILE: lib/acl/rte_acl.c:164:
+ return -ENOTSUP;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2002: FILE: lib/acl/rte_acl.c:165:
+ }$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2004: FILE: lib/acl/rte_acl.c:167:
+ return -EINVAL;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2015: FILE: lib/acl/rte_acl.c:242:
+ case RTE_ACL_CLASSIFY_S390X:$
ERROR:CODE_INDENT: code indent should use tabs where possible
#2016: FILE: lib/acl/rte_acl.c:243:
+ return acl_check_alg_s390x(alg);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2016: FILE: lib/acl/rte_acl.c:243:
+ return acl_check_alg_s390x(alg);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#2025: FILE: lib/acl/rte_acl.c:273:
+ RTE_ACL_CLASSIFY_S390X,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2025: FILE: lib/acl/rte_acl.c:273:
+ RTE_ACL_CLASSIFY_S390X,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2039: FILE: lib/acl/rte_acl.h:244:
+ RTE_ACL_CLASSIFY_S390X = 6, /**< requires s390x z13 support. */$
ERROR:C99_COMMENTS: do not use C99 // comments
#2090: FILE: lib/eal/s390x/include/rte_atomic.h:18:
+//#define dsb(opt) asm volatile("" : : : "memory")
ERROR:C99_COMMENTS: do not use C99 // comments
#2091: FILE: lib/eal/s390x/include/rte_atomic.h:19:
+//#define dmb(opt) asm volatile("" : : : "memory")
ERROR:C99_COMMENTS: do not use C99 // comments
#2093: FILE: lib/eal/s390x/include/rte_atomic.h:21:
+#define rte_mb() rte_compiler_barrier() //asm volatile("" : : : "memory")
ERROR:C99_COMMENTS: do not use C99 // comments
#2197: FILE: lib/eal/s390x/include/rte_cpuflags.h:23:
+ RTE_CPUFLAG_HPAGE, //from elf.h
ERROR:C99_COMMENTS: do not use C99 // comments
#2198: FILE: lib/eal/s390x/include/rte_cpuflags.h:24:
+ //RTE_CPUFLAG_EDAT, //from hwcap.h
ERROR:CODE_INDENT: code indent should use tabs where possible
#2304: FILE: lib/eal/s390x/include/rte_io.h:32:
+ union register_pair ioaddr_len =$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2304: FILE: lib/eal/s390x/include/rte_io.h:32:
+ union register_pair ioaddr_len =$
ERROR:CODE_INDENT: code indent should use tabs where possible
#2305: FILE: lib/eal/s390x/include/rte_io.h:33:
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2305: FILE: lib/eal/s390x/include/rte_io.h:33:
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#2305: FILE: lib/eal/s390x/include/rte_io.h:33:
+ union register_pair ioaddr_len =
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};
ERROR:CODE_INDENT: code indent should use tabs where possible
#2320: FILE: lib/eal/s390x/include/rte_io.h:48:
+ union register_pair ioaddr_len =$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2320: FILE: lib/eal/s390x/include/rte_io.h:48:
+ union register_pair ioaddr_len =$
ERROR:CODE_INDENT: code indent should use tabs where possible
#2321: FILE: lib/eal/s390x/include/rte_io.h:49:
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2321: FILE: lib/eal/s390x/include/rte_io.h:49:
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};$
ERROR:OPEN_BRACE: that open brace { should be on the previous line
#2321: FILE: lib/eal/s390x/include/rte_io.h:49:
+ union register_pair ioaddr_len =
+ {.even_odd.even = (uint64_t)ioaddr, .even_odd.odd = len};
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2442: FILE: lib/eal/s390x/include/rte_io.h:170:
+ rte_write32(value, addr);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#2640: FILE: lib/eal/s390x/include/rte_prefetch.h:39:
+ RTE_SET_USED(p);$
total: 113 errors, 122 warnings, 2795 lines checked
Warning in drivers/net/i40e/i40e_rxtx_vec_s390x.c:
Using compiler attribute directly
Warning in lib/eal/s390x/include/rte_atomic.h:
Using rte_smp_[r/w]mb
Warning in lib/eal/s390x/include/rte_spinlock.h:
Using __sync_xxx builtins
next parent reply other threads:[~2022-10-28 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221028215240.103365-1-dmiller423@gmail.com>
2022-10-28 21:54 ` checkpatch [this message]
2022-10-28 22:07 dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221028215410.CDFAF122B86@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=dmiller423@gmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).