From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: |WARNING| pw119638 [PATCH 02/14] cmdline: fix whitespace
Date: Wed, 9 Nov 2022 20:15:26 +0100 (CET) [thread overview]
Message-ID: <20221109191526.1E357121F24@dpdk.org> (raw)
In-Reply-To: <20221109191445.140320-3-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/119638
_coding style issues_
WARNING:BRACES: braces {} are not necessary for single statement blocks
#100: FILE: lib/cmdline/cmdline_parse_string.c:80:
+ if (strncmp(buf, str, token_len)) {
continue;
}
WARNING:BRACES: braces {} are not necessary for single statement blocks
#105: FILE: lib/cmdline/cmdline_parse_string.c:84:
+ if (!cmdline_isendoftoken(*(buf+token_len))) {
continue;
}
ERROR:SPACING: space prohibited after that open parenthesis '('
#111: FILE: lib/cmdline/cmdline_parse_string.c:89:
+ } while ( (str = get_next_token(str)) != NULL);
WARNING:BRACES: braces {} are not necessary for single statement blocks
#129: FILE: lib/cmdline/cmdline_parse_string.c:152:
+ while ((str = get_next_token(str)) != NULL) {
ret++;
}
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#160: FILE: lib/cmdline/cmdline_rdline.c:407:
+ while (CIRBUF_GET_LEN(&rdl->right) + CIRBUF_GET_LEN(&rdl->left) <
total: 1 errors, 4 warnings, 59 lines checked
parent reply other threads:[~2022-11-09 19:15 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20221109191445.140320-3-stephen@networkplumber.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221109191526.1E357121F24@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).