|WARNING| pw119933 [PATCH v1 1/1] app/testpmd: add valid check to verify multi mempool feature

|WARNING| pw119933 [PATCH v1 1/1] app/testpmd: add valid check to verify multi mempool feature

[qemudev]

Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/119933

_apply patch failure_

Submitter: Hanumanth Pothula <hpothula@marvell.com>
Date: Thu, 17 Nov 2022 17:00:47 +0530
DPDK git baseline: Repo:dpdk-next-net
  Branch: main
  CommitID: 04f68bb92b6fee621ddf0f0948f5565fa31a84fd

Apply patch set 119933 failed:

Checking patch app/test-pmd/testpmd.c...
error: while searching for:
{
	union rte_eth_rxseg rx_useg[MAX_SEGS_BUFFER_SPLIT] = {};
	struct rte_mempool *rx_mempool[MAX_MEMPOOL] = {};
	struct rte_mempool *mpx;
	unsigned int i, mp_n;
	int ret;

	/* Verify Rx queue configuration is single pool and segment or
	 * multiple pool/segment.
	 * @see rte_eth_rxconf::rx_mempools
	 * @see rte_eth_rxconf::rx_seg
	 */
	if (!(mbuf_data_size_n > 1) && !(rx_pkt_nb_segs > 1 ||
	    ((rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) != 0))) {
		/* Single pool/segment configuration */
		rx_conf->rx_seg = NULL;

error: patch failed: app/test-pmd/testpmd.c:2648
error: app/test-pmd/testpmd.c: patch does not apply

|SUCCESS| pw119933 [PATCH v1 1/1] app/testpmd: add valid check to verify multi mempool feature

[checkpatch]

Test-Label: checkpatch
Test-Status: SUCCESS
http://dpdk.org/patch/119933

_coding style OK_

|WARNING| pw119933 [PATCH] [v1, 1/1] app/testpmd: add valid check to verify multi mempool feature

[dpdklab]

[-- Attachment #1: Type: text/plain, Size: 2026 bytes --]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/119933

_apply patch failure_

Submitter: Hanumanth Reddy Pothula <hpothula@marvell.com>
Date: Thursday, November 17 2022 11:30:47 
Applied on: CommitID:903ec2b1b49e496815c016b0104fd655cd972661
Apply patch set 119933 failed:

Checking patch app/test-pmd/testpmd.c...
error: while searching for:
{
	union rte_eth_rxseg rx_useg[MAX_SEGS_BUFFER_SPLIT] = {};
	struct rte_mempool *rx_mempool[MAX_MEMPOOL] = {};
	struct rte_mempool *mpx;
	unsigned int i, mp_n;
	int ret;

	/* Verify Rx queue configuration is single pool and segment or
	 * multiple pool/segment.
	 * @see rte_eth_rxconf::rx_mempools
	 * @see rte_eth_rxconf::rx_seg
	 */
	if (!(mbuf_data_size_n > 1) && !(rx_pkt_nb_segs > 1 ||
	    ((rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) != 0))) {
		/* Single pool/segment configuration */
		rx_conf->rx_seg = NULL;

error: patch failed: app/test-pmd/testpmd.c:2648
Applying patch app/test-pmd/testpmd.c with 1 reject...
Rejected hunk #1.
diff a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c	(rejected hunks)
@@ -2648,16 +2648,22 @@ rx_queue_setup(uint16_t port_id, uint16_t rx_queue_id,
 {
 	union rte_eth_rxseg rx_useg[MAX_SEGS_BUFFER_SPLIT] = {};
 	struct rte_mempool *rx_mempool[MAX_MEMPOOL] = {};
+	struct rte_eth_dev_info dev_info;
 	struct rte_mempool *mpx;
 	unsigned int i, mp_n;
 	int ret;
 
+	ret = rte_eth_dev_info_get(port_id, &dev_info);
+	if (ret != 0)
+		return ret;
+
 	/* Verify Rx queue configuration is single pool and segment or
 	 * multiple pool/segment.
+	 * @see rte_eth_dev_info::max_rx_mempools
 	 * @see rte_eth_rxconf::rx_mempools
 	 * @see rte_eth_rxconf::rx_seg
 	 */
-	if (!(mbuf_data_size_n > 1) && !(rx_pkt_nb_segs > 1 ||
+	if (!(dev_info.max_rx_mempools != 0) && !(rx_pkt_nb_segs > 1 ||
 	    ((rx_conf->offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) != 0))) {
 		/* Single pool/segment configuration */
 		rx_conf->rx_seg = NULL;

https://lab.dpdk.org/results/dashboard/patchsets/24510/

UNH-IOL DPDK Community Lab