From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ke Zhang <ke1x.zhang@intel.com>
Subject: |WARNING| pw120142 [PATCH] net/ice: add devargs for disabling mac filter
Date: Fri, 25 Nov 2022 04:05:58 +0100 (CET) [thread overview]
Message-ID: <20221125030558.DFB7D12348D@dpdk.org> (raw)
In-Reply-To: <20221125025124.805466-1-ke1x.zhang@intel.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/120142
_coding style issues_
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY'
#163: FILE: drivers/net/ice/ice_generic_flow.c:2482:
+ if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+ && (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'actions[0].type == RTE_FLOW_ACTION_TYPE_DROP'
#163: FILE: drivers/net/ice/ice_generic_flow.c:2482:
+ if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+ && (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {
CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#164: FILE: drivers/net/ice/ice_generic_flow.c:2483:
+ if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+ && (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ad->devargs.mac_filter_disable == 1'
#177: FILE: drivers/net/ice/ice_generic_flow.c:2519:
+ if ((ad->devargs.mac_filter_disable == 1)
+ && (flow->rule == NULL)) {
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'flow->rule == NULL'
#177: FILE: drivers/net/ice/ice_generic_flow.c:2519:
+ if ((ad->devargs.mac_filter_disable == 1)
+ && (flow->rule == NULL)) {
CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#178: FILE: drivers/net/ice/ice_generic_flow.c:2520:
+ if ((ad->devargs.mac_filter_disable == 1)
+ && (flow->rule == NULL)) {
total: 0 errors, 0 warnings, 6 checks, 85 lines checked
next prev parent reply other threads:[~2022-11-25 3:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221125025124.805466-1-ke1x.zhang@intel.com>
2022-11-25 2:58 ` |SUCCESS| " qemudev
2022-11-25 3:02 ` qemudev
2022-11-25 3:05 ` checkpatch [this message]
2022-11-25 4:18 ` 0-day Robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125030558.DFB7D12348D@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=ke1x.zhang@intel.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).