From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B6C6AA0032
	for <public@inbox.dpdk.org>; Fri, 25 Nov 2022 04:06:00 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B2887410EF;
	Fri, 25 Nov 2022 04:06:00 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id F310F40150
 for <test-report@dpdk.org>; Fri, 25 Nov 2022 04:05:58 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id DFB7D12348D; Fri, 25 Nov 2022 04:05:58 +0100 (CET)
Subject: |WARNING| pw120142 [PATCH] net/ice: add devargs for disabling mac
 filter
In-Reply-To: <20221125025124.805466-1-ke1x.zhang@intel.com>
References: <20221125025124.805466-1-ke1x.zhang@intel.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Ke Zhang <ke1x.zhang@intel.com>
Message-Id: <20221125030558.DFB7D12348D@dpdk.org>
Date: Fri, 25 Nov 2022 04:05:58 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/120142

_coding style issues_


CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY'
#163: FILE: drivers/net/ice/ice_generic_flow.c:2482:
+		if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+			&& (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'actions[0].type == RTE_FLOW_ACTION_TYPE_DROP'
#163: FILE: drivers/net/ice/ice_generic_flow.c:2482:
+		if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+			&& (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#164: FILE: drivers/net/ice/ice_generic_flow.c:2483:
+		if ((pattern[0].type == RTE_FLOW_ITEM_TYPE_ANY)
+			&& (actions[0].type == RTE_FLOW_ACTION_TYPE_DROP)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'ad->devargs.mac_filter_disable == 1'
#177: FILE: drivers/net/ice/ice_generic_flow.c:2519:
+	if ((ad->devargs.mac_filter_disable == 1)
+		&& (flow->rule == NULL)) {

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'flow->rule == NULL'
#177: FILE: drivers/net/ice/ice_generic_flow.c:2519:
+	if ((ad->devargs.mac_filter_disable == 1)
+		&& (flow->rule == NULL)) {

CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#178: FILE: drivers/net/ice/ice_generic_flow.c:2520:
+	if ((ad->devargs.mac_filter_disable == 1)
+		&& (flow->rule == NULL)) {

total: 0 errors, 0 warnings, 6 checks, 85 lines checked