From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 359D1A0547
	for <public@inbox.dpdk.org>; Mon,  5 Dec 2022 21:25:10 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3183E40687;
	Mon,  5 Dec 2022 21:25:10 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id C360F40151
 for <test-report@dpdk.org>; Mon,  5 Dec 2022 21:25:07 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id C0AB1122CD9; Mon,  5 Dec 2022 21:25:07 +0100 (CET)
Subject: |WARNING| pw120461 [PATCH 1/3] eal: add rte control thread create API
In-Reply-To: <1670271868-11364-2-git-send-email-roretzla@linux.microsoft.com>
References: <1670271868-11364-2-git-send-email-roretzla@linux.microsoft.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>
Message-Id: <20221205202507.C0AB1122CD9@dpdk.org>
Date: Mon,  5 Dec 2022 21:25:07 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/120461

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

WARNING:FUNCTION_ARGUMENTS: function definition argument 'void *' should also have an identifier name
#69: FILE: lib/eal/common/eal_common_thread.c:238:
+		void * (*start_routine)(void *);

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#111: FILE: lib/eal/common/eal_common_thread.c:276:
+	if (0 != ctrl_thread_init(arg))

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#122: FILE: lib/eal/common/eal_common_thread.c:287:
+	if (0 != ctrl_thread_init(arg))

total: 0 errors, 4 warnings, 181 lines checked