From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4961BA0542
	for <public@inbox.dpdk.org>; Sat, 17 Dec 2022 19:00:33 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 42C8440E09;
	Sat, 17 Dec 2022 19:00:33 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 138364068E
 for <test-report@dpdk.org>; Sat, 17 Dec 2022 19:00:32 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id E7CD5122E70; Sat, 17 Dec 2022 19:00:31 +0100 (CET)
Subject: |WARNING| pw120991 [PATCH] lib/net: added push MPLS header API
In-Reply-To: <1671299997-13001-1-git-send-email-tanxeel1.ahmed@gmail.com>
References: <1671299997-13001-1-git-send-email-tanxeel1.ahmed@gmail.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Tanzeel-inline <tanxeel1.ahmed@gmail.com>
Message-Id: <20221217180031.E7CD5122E70@dpdk.org>
Date: Sat, 17 Dec 2022 19:00:31 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/120991

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#76: 
Push MPLS header after ethernet header, updates ethernet type and MPLS bs bit if required.

ERROR:TRAILING_WHITESPACE: trailing whitespace
#117: FILE: lib/net/rte_mpls.h:45:
+ * $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#121: FILE: lib/net/rte_mpls.h:49:
+ * $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#127: FILE: lib/net/rte_mpls.h:55:
+ *   0 on success, -1 on error (If no ethernet header exists)^I^I$

ERROR:TRAILING_WHITESPACE: trailing whitespace
#130: FILE: lib/net/rte_mpls.h:58:
+rte_mpls_push_over_l2(struct rte_mbuf **m, struct rte_mpls_hdr *mp) $

ERROR:TRAILING_WHITESPACE: trailing whitespace
#151: FILE: lib/net/rte_mpls.h:79:
+^I$

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#153: FILE: lib/net/rte_mpls.h:81:
+	if (nh->ether_type != rte_cpu_to_be_16(RTE_ETHER_TYPE_MPLS))
+	{

ERROR:TRAILING_WHITESPACE: trailing whitespace
#157: FILE: lib/net/rte_mpls.h:85:
+^I}^I$

ERROR:OPEN_BRACE: that open brace { should be on the previous line
#158: FILE: lib/net/rte_mpls.h:86:
+	else
+	{

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#158: FILE: lib/net/rte_mpls.h:86:
+	}	
+	else

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#164: FILE: lib/net/rte_mpls.h:92:
+	rte_memcpy(rte_pktmbuf_mtod_offset(*m, char*, sizeof(struct rte_ether_hdr)), mp, RTE_MPLS_HLEN);

ERROR:TRAILING_WHITESPACE: trailing whitespace
#165: FILE: lib/net/rte_mpls.h:93:
+^I$

ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Tanzeel-inline <tanxeel1.ahmed@gmail.com>'

total: 11 errors, 2 warnings, 78 lines checked
Tanzeel Ahmed <tanzeelahmed713@gmail.com> is unknown, please fix the commit message or update .mailmap.