From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ankur Dwivedi <adwivedi@marvell.com>
Subject: |WARNING| pw121268 [PATCH v4 1/6] eal: trace: add trace point emit for array
Date: Thu, 22 Dec 2022 07:38:31 +0100 (CET) [thread overview]
Message-ID: <20221222063831.37308122EC0@dpdk.org> (raw)
In-Reply-To: <20221222063306.3383695-2-adwivedi@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121268
_coding style issues_
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#201: FILE: lib/eal/include/rte_trace_point.h:381:
+#define rte_trace_point_emit_char_array(in, len) \
+do { \
+ if (unlikely(in == NULL)) \
+ return; \
+ if (len > __RTE_TRACE_EMIT_ARRAY_LEN_MAX) \
+ return; \
+ memcpy(mem, in, len); \
+ mem = RTE_PTR_ADD(mem, len); \
+} while (0)
WARNING:MACRO_WITH_FLOW_CONTROL: Macros with flow control statements should be avoided
#234: FILE: lib/eal/include/rte_trace_point_register.h:50:
+#define rte_trace_point_emit_char_array(in, len) \
+do { \
+ RTE_SET_USED(in); \
+ if (len > __RTE_TRACE_EMIT_ARRAY_LEN_MAX) \
+ return; \
+ __rte_trace_point_emit_field(len, RTE_STR(in)"[32]", "uint8_t"); \
+} while (0)
total: 0 errors, 2 warnings, 93 lines checked
parent reply other threads:[~2022-12-22 6:38 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20221222063306.3383695-2-adwivedi@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221222063831.37308122EC0@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=adwivedi@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).