From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ben Magistro <koncept1@gmail.com>
Subject: |WARNING| pw121509 [PATCH 5/6] app/dumpcap: improve per interface arg parsing
Date: Mon, 2 Jan 2023 17:26:42 +0100 (CET) [thread overview]
Message-ID: <20230102162642.C3E28122EC0@dpdk.org> (raw)
In-Reply-To: <20230102162441.6205-5-koncept1@gmail.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121509
_coding style issues_
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#82:
This change improves the argument parsing to align closer to that of Wireshark
ERROR:C99_COMMENTS: do not use C99 // comments
#127: FILE: app/dumpcap/main.c:79:
+//TODO this can be specified per interface but there are a few places
ERROR:C99_COMMENTS: do not use C99 // comments
#128: FILE: app/dumpcap/main.c:80:
+// that need more review and possibly refactoring so leaving this one out
ERROR:C99_COMMENTS: do not use C99 // comments
#283: FILE: app/dumpcap/main.c:360:
+ // pcap = pcap_open_dead(DLT_EN10MB, intf->start_opts->snaplen);
ERROR:SPACING: space prohibited before that close parenthesis ')'
#325: FILE: app/dumpcap/main.c:451:
+ if (interface_arg_count == 0 )
ERROR:C99_COMMENTS: do not use C99 // comments
#338: FILE: app/dumpcap/main.c:466:
+ // set interface to global parameters when new interface is configured
WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#343: FILE: app/dumpcap/main.c:471:
+ // interface_args[interface_arg_count - 1].snaplen = interface_defaults.snaplen;
ERROR:C99_COMMENTS: do not use C99 // comments
#343: FILE: app/dumpcap/main.c:471:
+ // interface_args[interface_arg_count - 1].snaplen = interface_defaults.snaplen;
ERROR:SPACING: space prohibited before that close parenthesis ')'
#352: FILE: app/dumpcap/main.c:480:
+ if (interface_arg_count == 0 )
WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#364: FILE: app/dumpcap/main.c:494:
+ /*
+ if (interface_arg_count == 0 )
WARNING:LONG_LINE_COMMENT: line length of 114 exceeds 100 columns
#367: FILE: app/dumpcap/main.c:497:
+ interface_args[interface_arg_count - 1].snaplen = get_uint(optarg, "snap_len", 0);
ERROR:C99_COMMENTS: do not use C99 // comments
#394: FILE: app/dumpcap/main.c:807:
+ // flags, intf->start_opts->snaplen,
total: 8 errors, 4 warnings, 325 lines checked
parent reply other threads:[~2023-01-02 16:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230102162441.6205-5-koncept1@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230102162642.C3E28122EC0@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=koncept1@gmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).