From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E4395A00C2
	for <public@inbox.dpdk.org>; Mon,  2 Jan 2023 17:26:44 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E045540693;
	Mon,  2 Jan 2023 17:26:44 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id C952A40689
 for <test-report@dpdk.org>; Mon,  2 Jan 2023 17:26:42 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id C3E28122EC0; Mon,  2 Jan 2023 17:26:42 +0100 (CET)
Subject: |WARNING| pw121509 [PATCH 5/6] app/dumpcap: improve per interface arg
 parsing
In-Reply-To: <20230102162441.6205-5-koncept1@gmail.com>
References: <20230102162441.6205-5-koncept1@gmail.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Ben Magistro <koncept1@gmail.com>
Message-Id: <20230102162642.C3E28122EC0@dpdk.org>
Date: Mon,  2 Jan 2023 17:26:42 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121509

_coding style issues_


WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#82: 
This change improves the argument parsing to align closer to that of Wireshark

ERROR:C99_COMMENTS: do not use C99 // comments
#127: FILE: app/dumpcap/main.c:79:
+//TODO this can be specified per interface but there are a few places

ERROR:C99_COMMENTS: do not use C99 // comments
#128: FILE: app/dumpcap/main.c:80:
+// that need more review and possibly refactoring so leaving this one out

ERROR:C99_COMMENTS: do not use C99 // comments
#283: FILE: app/dumpcap/main.c:360:
+		// pcap = pcap_open_dead(DLT_EN10MB, intf->start_opts->snaplen);

ERROR:SPACING: space prohibited before that close parenthesis ')'
#325: FILE: app/dumpcap/main.c:451:
+			if (interface_arg_count == 0 )

ERROR:C99_COMMENTS: do not use C99 // comments
#338: FILE: app/dumpcap/main.c:466:
+			// set interface to global parameters when new interface is configured

WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#343: FILE: app/dumpcap/main.c:471:
+			// interface_args[interface_arg_count - 1].snaplen = interface_defaults.snaplen;

ERROR:C99_COMMENTS: do not use C99 // comments
#343: FILE: app/dumpcap/main.c:471:
+			// interface_args[interface_arg_count - 1].snaplen = interface_defaults.snaplen;

ERROR:SPACING: space prohibited before that close parenthesis ')'
#352: FILE: app/dumpcap/main.c:480:
+			if (interface_arg_count == 0 )

WARNING:BLOCK_COMMENT_STYLE: Block comments use * on subsequent lines
#364: FILE: app/dumpcap/main.c:494:
+			/*
+			if (interface_arg_count == 0 )

WARNING:LONG_LINE_COMMENT: line length of 114 exceeds 100 columns
#367: FILE: app/dumpcap/main.c:497:
+				interface_args[interface_arg_count - 1].snaplen = get_uint(optarg, "snap_len", 0);

ERROR:C99_COMMENTS: do not use C99 // comments
#394: FILE: app/dumpcap/main.c:807:
+					   // flags, intf->start_opts->snaplen,

total: 8 errors, 4 warnings, 325 lines checked