From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ben Magistro <koncept1@gmail.com>
Subject: |WARNING| pw121505 [PATCH 1/6] app/dumpcap: add additional dump info
Date: Mon, 2 Jan 2023 17:26:52 +0100 (CET) [thread overview]
Message-ID: <20230102162652.2709B122EC0@dpdk.org> (raw)
In-Reply-To: <20230102162441.6205-1-koncept1@gmail.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121505
_coding style issues_
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#115: FILE: app/dumpcap/main.c:279:
+ if (rte_eth_link_get_nowait(p, &link_info) < 0) {
[...]
+ else if (link_info.link_status == RTE_ETH_LINK_UP) {
[...]
+ else {
[...]
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#118: FILE: app/dumpcap/main.c:282:
+ }
+ else if (link_info.link_status == RTE_ETH_LINK_UP) {
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#121: FILE: app/dumpcap/main.c:285:
+ }
+ else {
ERROR:C99_COMMENTS: do not use C99 // comments
#125: FILE: app/dumpcap/main.c:289:
+ // not checking error here; should only error if given an invalid port id
WARNING:BRACES: braces {} are not necessary for any arm of this statement
#126: FILE: app/dumpcap/main.c:290:
+ if (rte_eth_promiscuous_get(p) == 1) {
[...]
+ else {
[...]
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#129: FILE: app/dumpcap/main.c:293:
+ }
+ else {
total: 4 errors, 2 warnings, 58 lines checked
parent reply other threads:[~2023-01-02 16:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230102162441.6205-1-koncept1@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230102162652.2709B122EC0@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=koncept1@gmail.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).