From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 34B60A00C2
	for <public@inbox.dpdk.org>; Mon,  2 Jan 2023 17:26:54 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 30C8440693;
	Mon,  2 Jan 2023 17:26:54 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 2B18C40689
 for <test-report@dpdk.org>; Mon,  2 Jan 2023 17:26:52 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 2709B122EC0; Mon,  2 Jan 2023 17:26:52 +0100 (CET)
Subject: |WARNING| pw121505 [PATCH 1/6] app/dumpcap: add additional dump info
In-Reply-To: <20230102162441.6205-1-koncept1@gmail.com>
References: <20230102162441.6205-1-koncept1@gmail.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Ben Magistro <koncept1@gmail.com>
Message-Id: <20230102162652.2709B122EC0@dpdk.org>
Date: Mon,  2 Jan 2023 17:26:52 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121505

_coding style issues_


WARNING:BRACES: braces {} are not necessary for any arm of this statement
#115: FILE: app/dumpcap/main.c:279:
+		if (rte_eth_link_get_nowait(p, &link_info) < 0) {
[...]
+		else if (link_info.link_status == RTE_ETH_LINK_UP) {
[...]
+		else {
[...]

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#118: FILE: app/dumpcap/main.c:282:
+		}
+		else if (link_info.link_status == RTE_ETH_LINK_UP) {

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#121: FILE: app/dumpcap/main.c:285:
+		}
+		else {

ERROR:C99_COMMENTS: do not use C99 // comments
#125: FILE: app/dumpcap/main.c:289:
+		// not checking error here; should only error if given an invalid port id

WARNING:BRACES: braces {} are not necessary for any arm of this statement
#126: FILE: app/dumpcap/main.c:290:
+		if (rte_eth_promiscuous_get(p) == 1) {
[...]
+		else {
[...]

ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#129: FILE: app/dumpcap/main.c:293:
+		}
+		else {

total: 4 errors, 2 warnings, 58 lines checked