From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Amit Prakash Shukla <amitprakashs@marvell.com>
Subject: |WARNING| pw121784 [PATCH v1 2/3] graph: pcap capture for graph nodes
Date: Tue, 10 Jan 2023 13:01:03 +0100 (CET) [thread overview]
Message-ID: <20230110120103.859E81234F4@dpdk.org> (raw)
In-Reply-To: <20230110115847.1965096-2-amitprakashs@marvell.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/121784
_coding style issues_
ERROR:ELSE_AFTER_BRACE: else should follow close brace '}'
#163: FILE: lib/graph/graph_pcap_trace.c:65:
+ }
+ else
WARNING:TYPO_SPELLING: 'CREAT' may be misspelled - perhaps 'CREATE'?
#188: FILE: lib/graph/graph_pcap_trace.c:90:
+ fd = open(file_name, O_CREAT | O_TRUNC | O_WRONLY, 0664);
WARNING:TYPO_SPELLING: 'WRONLY' may be misspelled - perhaps 'WRONGLY'?
#188: FILE: lib/graph/graph_pcap_trace.c:90:
+ fd = open(file_name, O_CREAT | O_TRUNC | O_WRONLY, 0664);
WARNING:RETURN_VOID: void function return statements are not generally useful
#216: FILE: lib/graph/graph_pcap_trace.c:118:
+ return;
+}
ERROR:SPACING: space required before the open parenthesis '('
#242: FILE: lib/graph/graph_pcap_trace.c:144:
+ for(i = 0; i < num_packets; i++) {
total: 2 errors, 3 warnings, 332 lines checked
parent reply other threads:[~2023-01-10 12:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20230110115847.1965096-2-amitprakashs@marvell.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230110120103.859E81234F4@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=amitprakashs@marvell.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).